1558633 - Menulist on folderPane-toolbar has wrong colours with dark theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

When the dark theme is apllyed the menulist on the folderPane-toolbar doesn't get the correct colours of the dark theme.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1558633-dark-folderpane-mode-selector-menulist.patch

Alessandro, you can test it on Linux. Without patch and dark TB theme enabled, the menulist has a light gradient that makes the menulist too bright. With the patch the menulist looks like it should be (like the toolbar-buttons when they are hovered). Mac isn't affected because we still use the system appearance.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9071421 [details] [diff] [review]
1558633-dark-folderpane-mode-selector-menulist.patch

Review of attachment 9071421 [details] [diff] [review]:
-----------------------------------------------------------------

I like it.
I think we should use the same style for the buttons in the message header, since also those in dark mode on Linux look weird.
r+

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9071421 [details] [diff] [review]
1558633-dark-folderpane-mode-selector-menulist.patch

The regressing bug, the remove toolbars bug, is on beta too.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9071421 [details] [diff] [review]
1558633-dark-folderpane-mode-selector-menulist.patch

Going in now ;-)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d350f0aa49d5
Make it possible again to apply the dark theme to the folderPane-toolbar menulist. r=aleca DONTBUILD

Comment 6

[Jorg K (CEST = GMT+2)]

TB 68 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/e0294a2c7575d0b9f00070933098ea89255f2afc