Closed Bug 1558633 Opened 1 year ago Closed 1 year ago

Menulist on folderPane-toolbar has wrong colours with dark theme

Categories

(Thunderbird :: Theme, defect)

defect
Not set
normal

Tracking

(thunderbird68 fixed, thunderbird69 fixed)

RESOLVED FIXED
Thunderbird 69.0
Tracking Status
thunderbird68 --- fixed
thunderbird69 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

When the dark theme is apllyed the menulist on the folderPane-toolbar doesn't get the correct colours of the dark theme.

Alessandro, you can test it on Linux. Without patch and dark TB theme enabled, the menulist has a light gradient that makes the menulist too bright. With the patch the menulist looks like it should be (like the toolbar-buttons when they are hovered). Mac isn't affected because we still use the system appearance.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9071421 - Flags: review?(alessandro)
Comment on attachment 9071421 [details] [diff] [review]
1558633-dark-folderpane-mode-selector-menulist.patch

Review of attachment 9071421 [details] [diff] [review]:
-----------------------------------------------------------------

I like it.
I think we should use the same style for the buttons in the message header, since also those in dark mode on Linux look weird.
r+
Attachment #9071421 - Flags: review?(alessandro) → review+
Keywords: checkin-needed
Comment on attachment 9071421 [details] [diff] [review]
1558633-dark-folderpane-mode-selector-menulist.patch

The regressing bug, the remove toolbars bug, is on beta too.
Attachment #9071421 - Flags: approval-comm-beta?
Comment on attachment 9071421 [details] [diff] [review]
1558633-dark-folderpane-mode-selector-menulist.patch

Going in now ;-)
Attachment #9071421 - Flags: approval-comm-beta? → approval-comm-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d350f0aa49d5
Make it possible again to apply the dark theme to the folderPane-toolbar menulist. r=aleca DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0
You need to log in before you can comment on or make changes to this bug.