1558715 - Thunberbird 68.0b1 release: Beetmover moving files to wrong location

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

Attachment: beetmover_artifact_map.png

During Thunderbird-68.0b1 promote phase, the Update Verify tasks all failed. The beetmover tasks read the wrong artifact map files and put things in the wrong place. (See attachment)

Comment 1

[Rob Lemley [:rjl]]

Attachment: beetmover-artifact_map.patch

The new taskgraph shows that the correct artifact-map will get used:

```
"beetmover-repackage-linux64-shippable/opt": {
  "attributes": {
    "always_target": false,
    "artifact_map": "comm/taskcluster/comm_taskgraph/manifests/thunderbird_candidates.yml",
    "build_platform": "linux64-shippable",
    "build_type": "opt",
    "kind": "beetmover-repackage",
```

Comment 2

[Rob Lemley [:rjl]]

Attachment: corrected_beetmover_artifact_map.png

Comment 3

[Rob Lemley [:rjl]]

This only needs to go on beta, "by-release-type" should be okay on central.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9071496 [details] [diff] [review]
beetmover-artifact_map.patch

OK. I wondered back in the days of uplifting this
https://hg.mozilla.org/releases/comm-beta/rev/002469441c43eec71db4fbc2eb4a1142c4ac7a35#l2.2
whether `by-release-type` wasn't too "modern" to work.

Any reason why you're reshuffling the order? default typically comes last, no, although it doesn't matter.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9071496 [details] [diff] [review]
beetmover-artifact_map.patch

Review of attachment 9071496 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/beetmover-checksums/kind.yml
@@ +22,5 @@
>          artifact_prefix: public
>          artifact_map:
> +            by-project:
> +                default: comm/taskcluster/comm_taskgraph/manifests/thunderbird_nightly.yml
> +                comm-(beta|esr60|esr68): comm/taskcluster/comm_taskgraph/manifests/thunderbird_candidates.yml

Actually, that's a copy/paste error, no? It was thunderbird_nightly_checksums.yml

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: Original patch with default last

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: Modified patch

Correcting the alleged copy/paste error. I'm not 100% sure, so I won't land this now.

Comment 8

[Rob Lemley [:rjl]]

Yes, it should be checksums.

(In reply to Jorg K (GMT+2) from comment #5)

Comment on attachment 9071496 [details] [diff] [review]
beetmover-artifact_map.patch
::: taskcluster/ci/beetmover-checksums/kind.yml
@@ +22,5 @@

     artifact_prefix: public
     artifact_map:

•        by-project:
  

•            default: comm/taskcluster/comm_taskgraph/manifests/thunderbird_nightly.yml
  

•            comm-(beta|esr60|esr68): comm/taskcluster/comm_taskgraph/manifests/thunderbird_candidates.yml
  

Actually, that's a copy/paste error, no? It was
thunderbird_nightly_checksums.yml

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9071545 [details] [diff] [review]
Original patch with default last

Marking as obsolete due to error pointed out in comment 5.

Comment 10

[Jorg K (CEST = GMT+2)]

OK, I'm still playing with chat badges, and we have bug 1558778 / bug 1558790. So I'll land this later.

Comment 11

[Jorg K (CEST = GMT+2)]

TB 68 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/c27525ab726e477888d64f34defa3dcd1abe2b88

Comment 12

[Rob Lemley [:rjl]]

Attachment: remove_bz2_mar.patch

Will need uplift to beta.

Comment 13

[Rob Lemley [:rjl]]

Attachment: source_checksum_prefix.patch

Uplift to beta

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6c271e995e80
Followup: Remove bz2.mar file from artifact manifest. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/05fc0c90a102
Followup: Look for source checksums in public prefix. rs=bustage-fix

Comment 15

[Jorg K (CEST = GMT+2)]

Attachment: Follow up, follow-up, followup

Some pedantic notes: If you have review, why not include it in the commit message, so r=darktrojan. Also, see picture ;-)

Comment 16

[Rob Lemley [:rjl]]

Attachment: installer_capitalization.patch

Reviewed output of mach taskgraph full to verify no more instances of
incorrect capitalization.

Comment 17

[Rob Lemley [:rjl]]

Comment on attachment 9071949 [details] [diff] [review]
installer_capitalization.patch

Affecting the 68.0b1 release process.

Comment 18

[Jorg K (CEST = GMT+2)]

Comment on attachment 9071949 [details] [diff] [review]
installer_capitalization.patch

Sigh, I messed that up when copying those files in a cloak-and-dagger operative under bustage-fix pressure :-(

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eaeb15a4f683
Follow-up: Capitalize Win and Mac installer downloads. r=jorgk DONTBUILD

Comment 20

[Jorg K (CEST = GMT+2)]

TB 68 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/f87460c79c5759ad1384841c3dd0f8933d242414