layers.acceleration.disabled preference use is likely incorrect
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(1 file)
As seen in https://treeherder.mozilla.org/logviewer.html#?job_id=251294067&repo=autoland
We have
Assertion failure: staticPrefValue == preferenceValue (Preference 'layers.acceleration.disabled' got modified since StaticPrefs::LayersAccelerationDisabledDoNotUseDirectly got initialized. Consider using a Live StaticPrefs instead), at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h:3436
This indicates that a StaticPrefs using the preference layers.acceleration.disabled is defined with a Once policy, yet the preference is modified by tests after the StaticPrefs are initialized.
The method StaticPrefs::LayersAccelerationDisabledDoNotUseDirectly() is used once at startup. So while changing this StaticPrefs to be live will allow bug 1556131 to be completed it still indicates that the tests of this prefs are likely wrong.
Modifying this pref will require a restart for the gfx code to account for the change.
|
||
Comment 1•5 years ago
|
||
Apparently this is not the first time this has come up, see https://bugzilla.mozilla.org/show_bug.cgi?id=919434#c13
My vote is to just remove the crashtest entirely since it's obviously not testing what it was supposed to test. That way we get rid of the crashtest annotation that is trying to flip this pref.
|
Assignee | |
Comment 2•5 years ago
|
||
The test is supposed to test that changing the preference layers.acceleration.disabled doesn't cause a crash, but this pref is only read on startup well before the test has a chance to run and switch the pref.
It's not doing anything.
|
|
Assignee | |
Updated•5 years ago
|
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a4db4efaef6 Remove non-functional test. r=kats
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Description
•