1558775 - The "Confirm and Restart" button on the Preference tab for switching to another locale doesn't work

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

When you have an extra language pack installed and exposed the GUI by toggling the pref intl.multilingual.enabled to true, the button to change to new locale doesn't work. See the following message in the errorconsole:
TypeError: event is undefined
confirmLanguageChange chrome://messenger/content/preferences/advanced.js:728
showConfirmLanguageChangeMessageBar chrome://messenger/content/preferences/advanced.js:705

When looking at the code, I see that in addEventListener no event is passed to the function:
https://searchfox.org/comm-central/source/mail/components/preferences/advanced.js#746
button.addEventListener("command", () => gAdvancedPane.confirmLanguageChange());

Maybe something like this fixes it?
button.addEventListener("command", (event) => gAdvancedPane.confirmLanguageChange(event));

Comment 1

[Jorg K (CEST = GMT+2)]

I didn't say "Assign to Richard", I said, NI him. That stuff is ported from M-C and it looks different there:
https://searchfox.org/mozilla-central/rev/c606cdd6d014fee4034da1702d484c0d41b604c9/browser/components/preferences/in-content/main.js#810

Comment 2

[Jorg K (CEST = GMT+2)]

I'm pushing a fix now, sadly I can't test it on trunk, but it won't get any worse ;-) - Richard, can you please look whether it's still working on trunk.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08f782cdbba0
Revert part of rev 423c3668781b (bug 1547581) to fix new language 'confirm and restart' button. a=backout DONTBUILD

Comment 4

[Jorg K (CEST = GMT+2)]

TB 68 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/cfc0d18189f4af2f99d2bd6bba902bb3049d9c63

Should be fixed, we'll have to see.

Comment 5

[Jorg K (CEST = GMT+2)]

(In reply to Jorg K (GMT+2) from comment #2)

I'm pushing a fix now, sadly I can't test it on trunk, but it won't get any worse ;-) - Richard, can you please look whether it's still working on trunk.

Axel mentioned on IRC that it's broken and he'll file a bug for it. Apparently some Fluent "no bundle was loaded" error.

Comment 6

[:aceman]

Thanks, the change may work but reverting this goes against the idea of bug 1547581.
Can we rather add the event argument as in comment 0?

Comment 7

[Jorg K (CEST = GMT+2)]

Well, that code needs to be kept 100% in sync with M-C for easier porting. If they don't do it, we don't do it. You can apply your new goodness anywhere else ;-)

Comment 8

[Jorg K (CEST = GMT+2)]

Hmm, I can't test this since I'm running into bug 1558859. How did you manage to install the additional message in the first place? Is it fixed in beta 1 build 2?

Comment 9

[Richard Marti (:Paenglab)]

A installed language should be shown already in the menulist on Advanced itself. And here you can select your language.

I tried it on tip and this works, it asks for restart. I see bug 1558859 too. This dialog is to sort/add/remove the languages.

Comment 10

[Onno Ekker [:nONoNonO UTC+1]]

I downloaded 68.0b1 from http://archive.mozilla.org/pub/thunderbird/nightly/latest-comm-beta/ and the language pack from http://archive.mozilla.org/pub/thunderbird/nightly/latest-comm-beta-l10n/win32/xpi/ and installed it from the add-ons manager.

Comment 11

[Jorg K (CEST = GMT+2)]

Sure, but to set a new language you run into bug 1558859. Anyway, I'll put that on the beta and then we'll see.

EDIT: Sorry, comment #9, the languages are already on the menu list. Case closed. I verified the beta patch on a try build.