Closed
Bug 1558776
Opened 5 years ago
Closed 5 years ago
Extract callback timeout handler and script timeout handler from nsJSScriptTimeoutHandler
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
nsJSScriptTimeoutHandler has two different types of handler
1). Callback function
2). Script text
This bug is to extract the callback function part into a separated class.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → echen
|
|
Assignee | |
Comment 1•5 years ago
|
||
Bug 1198381 missed out moving this comment to nsITimoutHandler
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Summary: Extract callback-function handling from nsJSScriptTimeoutHandler → Extract callback timeout handler and script timeout handler from nsJSScriptTimeoutHandler
|
||
Updated•5 years ago
|
Attachment #9071581 -
Attachment description: Bug 1558776 - Fix comment of nsITimeoutHandler::GetLocation; → Bug 1558776 - Part 1: Fix comment of nsITimeoutHandler::GetLocation;
|
|
||
Updated•5 years ago
|
Attachment #9071867 -
Attachment description: Bug 1558776 - Extract callback timeout handler from nsJSScriptTimeoutHandler; → Bug 1558776 - Part 2: Extract callback timeout handler from nsJSScriptTimeoutHandler;
|
|
||
Updated•5 years ago
|
Attachment #9071877 -
Attachment description: Bug 1558776 - Extract script timeout handler from nsJSScriptTimeoutHandler; → Bug 1558776 - Part 3: Extract script timeout handler from nsJSScriptTimeoutHandler;
|
|
||
Updated•5 years ago
|
Attachment #9071886 -
Attachment description: Bug 1558776 - Merge nsITimeoutHandler and TimeoutHandler; → Bug 1558776 - Part 4: Merge nsITimeoutHandler and TimeoutHandler;
|
|
Assignee | |
Comment 8•5 years ago
|
||
This refactoring is for bug 1185052, so that we could just handle the propagation of user-interaction inside *TimeoutHandler.
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ffd9ef276dfb Part 1: Fix comment of nsITimeoutHandler::GetLocation; r=smaug https://hg.mozilla.org/integration/autoland/rev/9efd0501eae8 Part 2: Extract callback timeout handler from nsJSScriptTimeoutHandler; r=smaug https://hg.mozilla.org/integration/autoland/rev/b23807668491 Part 3: Extract script timeout handler from nsJSScriptTimeoutHandler; r=smaug https://hg.mozilla.org/integration/autoland/rev/ce739f305797 Part 4: Merge nsITimeoutHandler and TimeoutHandler; r=smaug
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ffd9ef276dfb
https://hg.mozilla.org/mozilla-central/rev/9efd0501eae8
https://hg.mozilla.org/mozilla-central/rev/b23807668491
https://hg.mozilla.org/mozilla-central/rev/ce739f305797
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•