Closed Bug 1558784 Opened 5 months ago Closed 5 months ago

[about:addons] Abuse report error when trying to submit it for an extension with summary too long

Categories

(Toolkit :: Add-ons Manager, defect)

69 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox68 --- verified
firefox69 --- verified

People

(Reporter: vcarciu, Assigned: rpl)

References

Details

Attachments

(3 files)

Reproducible on both Windows 10x64, and macOS 10.14.5 for latest FF Beta and Nightly

Steps to reproduce:
1.Install a theme/extension with a long summary (https://addons-dev.allizom.org/en-US/firefox/addon/aspergers-color-dance/)
2.Go to about:addons and try to send an abuse report for it

Expected results:
Abuse report is correctly sent

Actual results:
An error is returned :"Error submitting abuse report for {b32c8d2b-0c0a-42d8-9a35-9c66f4d203c1} AbuseReportError: "ERROR_CLIENT - {"status":400,"responseText":"{"addon_summary":["Ensure this field has no more than 255 characters."]}"}""

Please see the attached video for the issue.

Note: at the moment, all string fields in the abuse reporting API have a 255 chars limit except the user message which is unlimited (would make sense to add a limit there too, though, and truncate in the client as well).

Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/14da3b0ad462
Truncate abuse report properties that may be longer than allowed by the API endpoint. r=mixedpuppy
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → lgreco

Comment on attachment 9071707 [details]
Bug 1558784 - Truncate abuse report properties that may be longer than allowed by the API endpoint. r?mixedpuppy!

Beta/Release Uplift Approval Request

  • User impact if declined: An extension may prevent a user from submitting an abuse report by including a description (or a name) longer than allowed by the AMO API endpoint.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Not strictly necessary (as it is explicitly tested in the new test case included along with the fix), but QA can verify it explicitly using the STR from Comment 0.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change is restricted to the AbuseReport.jsm, small (most of the patch in the new test case), and tested in automation.
  • String changes made/needed:
Attachment #9071707 - Flags: approval-mozilla-beta?

Verified as fixed in Firefox Nightly 69.0a1 (2019-06-13) on Windows 10x64 and macOS 10.14.5

Please see postfix video attached

Status: RESOLVED → VERIFIED
Attached image Postfix Screenshot

(In reply to Luca Greco [:rpl] from comment #5)

Comment on attachment 9071707 [details]
Bug 1558784 - Truncate abuse report properties that may be longer than allowed by the API endpoint. r?mixedpuppy!

  • List of other uplifts needed: None

I should have mentioned that this change has been applied on Nightly on top of Bug 1558305 (which has its own uplift request: Bug 1558305 Comment 9).

Comment on attachment 9071707 [details]
Bug 1558784 - Truncate abuse report properties that may be longer than allowed by the API endpoint. r?mixedpuppy!

fix for addons abuse reporting, approved for 68.0b11

Attachment #9071707 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified the uplift in FF 68.0b11 (64-bit) on Windows 10x64 and macOS 10.14.5 and everything looks fine.

Marking bug as verified for 68

You need to log in before you can comment on or make changes to this bug.