1558790 - Fluent in TB preferences not set up OK

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Axel Hecht [:Pike]]

There's some problem with Fluent in preferences.

If you open the prefs, the js console shows an error:

[fluent] Request for keys failed because no resource bundles got generated.
 keys: [{"args":null,"id":"choose-messenger-language-description"},{"args":null,"id":"manage-messenger-languages-button"}].
 resourceIds: ["branding/brand.ftl","messenger/preferences/preferences.ftl","messenger/preferences/fonts.ftl","messenger/preferences/languages.ftl"]. Localization.jsm:202:13

Not exactly sure why that is, I think the files are all there. Which would be one possible reason. Or something's not working on the IO/L10nRegistry side.

Comment 1

[Axel Hecht [:Pike]]

L10nRegistry.sources.get('0-toolkit')
{}
cache: Object { "resource://gre/localization/de/messenger/preferences/preferences.ftl": false,  … }
indexed: false
locales: Array [ "de" ]
name: "0-toolkit"
prePath: "resource://gre/localization/{locale}/"

Many things don't look right here. In particular, that we don't have en-US in the locales of the toolkit source.

Comment 2

[Axel Hecht [:Pike]]

Also, Services.locale.packagedLocales is just ['de'] instead of ['de', 'en-US'].

Comment 3

[Axel Hecht [:Pike]]

Rambling, sorry:

https://searchfox.org/comm-central/source/mozilla/browser/locales/Makefile.in#69 doesn't exist in comm-*, which is probably the reason why there's no res/multilocale.txt in TB, AFAICT.

Moving over to build config tentatively, it's surely not Preferences at this point.

Comment 4

[Jorg K (CEST = GMT+2)]

Axel, can you please fix the formatting in comment #1.

Comment 6

[Jorg K (CEST = GMT+2)]

Hmm, over in bug 1558775 comment #2 I noticed that the language adding/switching in the advanced prefs doesn't appear to work. That's the same issue, right?

Comment 7

[Axel Hecht [:Pike]]

(In reply to Jorg K (GMT+2) from comment #6)

Hmm, over in bug 1558775 comment #2 I noticed that the language adding/switching in the advanced prefs doesn't appear to work. That's the same issue, right?

I don't know.

Comment 8

[Axel Hecht [:Pike]]

Tested a local patch, taking.

Comment 9

[Axel Hecht [:Pike]]

Attachment: Bug 1558790, ensure multilocale.txt is in repacks in comm, r=rjl

Comment 10

[Jorg K (CEST = GMT+2)]

Thanks, Axel, this was suggested on IRC:
14:32:30 - Paenglab_work: jorgk: Beta needs the port of https://searchfox.org/comm-central/source/mozilla/browser/locales/Makefile.in#69 too.

More precisely:
https://searchfox.org/mozilla-central/rev/c606cdd6d014fee4034da1702d484c0d41b604c9/browser/locales/Makefile.in#69

I filed bug 1558859 for the issue mentioned in comment #2.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11a90453a1d3
ensure multilocale.txt is in repacks in comm. r=rjl DONTBUILD

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 9071629 [details]
Bug 1558790, ensure multilocale.txt is in repacks in comm, r=rjl

[Approval Request Comment]
Regression caused by (bug #): we never ported this, but the m-c patch that started using this landed in gecko 60
User impact if declined: Fluent-localized UI won't work.
Testing completed (on c-c, etc.): Tested locally on a build
Risk to taking this patch (and alternatives if risky): Low.

Comment 13

[Jorg K (CEST = GMT+2)]

Comment on attachment 9071629 [details]
Bug 1558790, ensure multilocale.txt is in repacks in comm, r=rjl

TB 68 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/e9ab29bd76f374c8c47cb0a1b399ea91fbc0b9b0

Comment 14

[Jorg K (CEST = GMT+2)]

Thanks, Axel!

Comment 15

[Jorg K (CEST = GMT+2)]

I downloaded
https://queue.taskcluster.net/v1/task/Sk_bJivmTROJxh3fdocDWw/runs/0/artifacts/public/build/da/target.zip
from Rob's try build at
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7136d7f865a614f7cfefa4756cdccd8e98328012
and ran it.

I opened the Troubleshooting page (reported blank in bug 1558778) and got:
Denne side indeholder teknisk information som måske kan være brugbar når du forsøger at løse et problem. Hvis du leder efter svar på ofte spurgte spørgsmål om Thunderbird, kan du besøge vores

Looks like Danish and not blank at all.