1558860 - Adapt Thunderbird to HTML about:addons

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | comm/mail/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | uncaught exception - TypeError: gListView.node is null at @chrome://messenger/content/aboutAddonsExtra.js:75:3

Also in a local build:
TypeError: gListView.node is null aboutAddonsExtra.js:75:3
<anonymous> chrome://messenger/content/aboutAddonsExtra.js:75
<anonymous> chrome://messenger/content/aboutAddonsExtra.js:76
inContentOverlays chrome://messenger/content/specialTabs.js:286
onLoad chrome://messenger/content/specialTabs.js:369

Looks like it's from the last merge:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=43b2d57b25cc16d0571e6bef6a414abe24&tochange=e7e81a32c2ab11f089f9c53eab71da9490

Totally wild guess:
Bug 1553200 - Do not receive unwanted nsIWebProgress events in addon discovery view r=mconley
since that bug modified toolkit/mozapps/extensions/content/extensions.js which uses gListView.

Comment 1

[Jorg K (CEST = GMT+2)]

BTW, on trunk, listing addons in the add-ons manager and then clicking on one to see details is broken, that is gives a blank page. And there is a strange new "options" pulldown to disable and enable. And our "restart" button is gone.

I'm again at a stage were Calendar is active in the Options, but all other menu items are gone. Sound a bit like bug 1477506. Usually running another local build or disabling/removing it, resetting the magic "distro" pref would eventually bring it back, but no luck today.

Even on a new profile, Calendar isn't there although present in the options.

Oh, I did another 'mach build' and there is the Calendar. So strange.

Comment 2

[Geoff Lankow (:darktrojan)]

Bug 1555012. I'm going to disable it for now until I can make the appropriate changes.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/32910388a6ee
Temporarily disable new about:addons page; rs=bustage-fix DONTBUILD

Comment 4

[Richard Marti (:Paenglab)]

The HTML about:addons are going to 68 too. The fixes will be needed there too.

PS: I noticed that dragging a XPI over the right part of the HTML about:addons doesn't work. The left part still works.

Comment 5

[Jorg K (CEST = GMT+2)]

TB 68 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/c684a651ba8fa1939c96536f3e3983635005bcfd
Bug 1555012 was uplifted to FF 68 beta 10.

Comment 6

[Rob Wu [:robwu]]

(In reply to Richard Marti (:Paenglab) from comment #4)

The HTML about:addons are going to 68 too. The fixes will be needed there too.

PS: I noticed that dragging a XPI over the right part of the HTML about:addons doesn't work. The left part still works.

FYI that is bug 1559392. Though according to comments in that bug, xpis work fine, but zips don't.

Comment 7

[Geoff Lankow (:darktrojan)]

I'm going to call our reverting to the old about:addons "fixed".