1558867 - Android 'mach gtest <test>' sometimes fails: gtest | org.mozilla.geckoview.test failed to start

Status: RESOLVED FIXED

(Testing :: GTest, defect)

Description

[Geoff Brown [:gbrown]]

mach gtest "APZ*"
...
gtest INFO | Running Android gtest
 1:02.95 gtest INFO Granting important runtime permissions to org.mozilla.geckoview.test
 1:06.71 gtest INFO launch_application: am start -W -n org.mozilla.geckoview.test/org.mozilla.geckoview.test.TestRunnerActivity -a android.intent.action.MAIN --es env9 MOZ_GTEST_CWD=/sdcard/tests/gtest-profile --es env8 MOZ_GTEST_MINIDUMPS_PATH=/sdcard/tests/gtest-minidumps --es args "-unittest --gtest_death_test_style=threadsafe -profile /sdcard/tests/gtest-profile" --es env3 GTEST_FILTER=APZ* --es env2 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_TBPL_PARSER=1 --es env0 MOZ_CRASHREPORTER=1 --es env7 MOZ_CRASHREPORTER_NO_REPORT=1 --es env6 MOZ_RUN_GTEST=1 --es env5 MOZ_IN_AUTOMATION=1 --es env4 MOZ_GTEST_LOG_PATH=/sdcard/tests/gtest.log --ez use_multiprocess False
gtest TEST-UNEXPECTED-FAIL | gtest | org.mozilla.geckoview.test failed to start

...but 'adb logcat' shows that the requested tests ran:

...
06-12 18:01:46.449 12701 12716 I gtest   : TEST-START | APZCSnappingTester.Snap_After_Pinch
06-12 18:01:46.450 12701 12716 I gtest   : TEST-PASS | APZCSnappingTester.Snap_After_Pinch | test completed (time: 0ms)
06-12 18:01:46.450 12701 12716 I gtest   : TEST-PASS | GTest unit test: passed
06-12 18:01:46.450 12701 12716 I gtest   : Passed: 30
06-12 18:01:46.450 12701 12716 I gtest   : Failed: 0

Comment 1

[Geoff Brown [:gbrown]]

It looks like this is just a race on startup: If the log is not present when the harness first checks for it, and the remote app completes before the harness confirms it was running, no log is reported, and the harness times out waiting for startup.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: Bug 1558867 - Report log for short runs of 'mach gtest'; r=bc

This allows me to run 'mach gtest "APZ*"' and other short runs of gtest
that were previously failing.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ec524b6ce7d
Report log for short runs of 'mach gtest'; r=bc

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6ec524b6ce7d