1558884 - Cleanup _pauseAndRespond method on DevTools Thread actor

Status: NEW

(DevTools :: Debugger, task, P3)

Description

[Julian Descottes [:jdescottes]]

The current _pauseAndRespond method in the DevTools thread actor has several issues:

• it's hinted as private, but it's called from the Breakpoint actor (https://searchfox.org/mozilla-central/rev/227f5329f75bd8b16c6b146a7414598a420260cb/devtools/server/actors/breakpoint.js#257)
• the return values don't make any sense (undefined : null?)
• it seems most of the call sites don't actually use the return value?
• this method is the only reason why we have a _parentClosed field on the Thread actor, which being toggled from the browsing-context actor.
• this method sends packets on the connection, even though it can be called outside of a request

Some improvements will come with Bug 1494796, but there is a lot left to do.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Jason Laster [:jlast]]

_pauseAndRespond is super weird.

• I agree we should make it public
• undefined and null are special values for whether we should resume or suspend execution.
• if we pause we want to notify the client
• i'll look at the parentClosed field