1558890 - OSX Mojave (10.14) - VideoFrameConverterTest.ClearFutureFramesOnJumpingBack | Expected: (TimeStamp::Now()) < (future2), actual: 8-byte object <8E-AB 7B-25 A4-05 00-00> vs 8-byte object <60-FB 79-A8 A3-05 00-00> @ /builds/worker/workspace/build/src/dom/med

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=251074328&repo=try
Full log: https://queue.taskcluster.net/v1/task/MSgzLG2BQAa3UuzSunBogw/runs/0/artifacts/public/logs/live_backing.log

---

Context:
02:20:47 INFO - TEST-START | VideoFrameConverterTest.ClearFutureFramesOnJumpingBack
02:20:48 WARNING - TEST-UNEXPECTED-FAIL | VideoFrameConverterTest.ClearFutureFramesOnJumpingBack | Expected: (TimeStamp::Now()) < (future2), actual: 8-byte object <8E-AB 7B-25 A4-05 00-00> vs 8-byte object <60-FB 79-A8 A3-05 00-00> @ /builds/worker/workspace/build/src/dom/media/gtest/TestVideoFrameConverter.cpp:203
02:20:48 WARNING - TEST-UNEXPECTED-FAIL | VideoFrameConverterTest.ClearFutureFramesOnJumpingBack | Expected equality of these values:
02:20:48 INFO - frames[1].first().width()
02:20:48 INFO - Which is: 640
02:20:48 INFO - 320 @ /builds/worker/workspace/build/src/dom/media/gtest/TestVideoFrameConverter.cpp:208
02:20:48 WARNING - TEST-UNEXPECTED-FAIL | VideoFrameConverterTest.ClearFutureFramesOnJumpingBack | Expected equality of these values:
02:20:48 INFO - frames[1].first().height()
02:20:48 INFO - Which is: 480
02:20:48 INFO - 240 @ /builds/worker/workspace/build/src/dom/media/gtest/TestVideoFrameConverter.cpp:209
02:20:48 WARNING - TEST-UNEXPECTED-FAIL | VideoFrameConverterTest.ClearFutureFramesOnJumpingBack | test completed (time: 1249ms)

Comment 1

[Edwin Takahashi (:egao | infrequent contributor)]

:drno - this is a new permafail observed on macosx1014-64-shippable/opt. Interestingly, this failure is not reproducible on macosx1014-64/debug. Could you please take a look, or pass the ni on to someone that may be able to comment, thank you.

Comment 2

[Intermittent Failures Robot]

1 failures in 4753 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1558890&startday=2019-06-10&endday=2019-06-16&tree=all

Comment 3

[Edwin Takahashi (:egao | infrequent contributor)]

:apehrson - I see that you added this test back in March 2019, could you please help with why this test is failing on macosx1014 specifically? This is an example to the try push: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=253415686&searchStr=gtest&revision=be2fd4bee7ac908b84bbdb5a8458b184158d6ce0

Comment 4

[Andreas Pehrson [:pehrsons]]

Interesting. Will take a look!

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1558890 - Give more leeway to VideoFrameConverterTest::ClearFutureFramesOnJumpingBack. r?dminor

This does two things:

• Makes times relative to current time, with the only constraint that not a
  whole second may pass after the first frame, since that will trigger the
  same-frame timer.
• Changes asserts to use TimeDuration instead of TimeStamp for understandable
  logs.

This has proven needed on some macosx machines.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a81e4b801a1
Give more leeway to VideoFrameConverterTest::ClearFutureFramesOnJumpingBack. r=dminor

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2a81e4b801a1