1558917 - Referrer no longer sent for new tab links

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ed Lee :Mardak]

Bug 1517703 changed the win.openLinkIn API from taking a params with {referrerPolicy, referrerURI} to {referrerInfo} This affects 67

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1558917 - Referrer no longer sent for new tab links

Comment 2

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Publishers are expecting the referrer to attribute traffic to pocket

Comment 3

[Ed Lee :Mardak]

Attachment: example good referrer

QA steps:

1. open new tab with articles
2. open Browser Toolbox (alt-shift-cmd-I)
3. switch to Network view
4. click an article (good to note the url to search for it in toolbar)

expected results:
network request to the article (select the url in left panel; probably the first html request) has a Request Header (right panel) containing "Referer: https://getpocket.com/recommendations"

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dac8ade6630
Referrer no longer sent for new tab links r=thecount

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9dac8ade6630

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (69.0a1 Build ID - 20190617214029) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Referer: https://getpocket.com/recommendations" string is displayed in the "Request Header" section.

Comment 7

[Ed Lee :Mardak]

Comment on attachment 9072254 [details]
Bug 1558917 - Referrer no longer sent for new tab links

Beta/Release Uplift Approval Request

• User impact if declined: User interest in publisher's articles don't get attributed back to pocket
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 3
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Updating new tab's link opening API call to the new API
• String changes made/needed: none

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9072254 [details]
Bug 1558917 - Referrer no longer sent for new tab links

regression fix, approved for 68.0b12

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a78204125055

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (68.0b12 Build ID - 20190619234730) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Referer: https://getpocket.com/recommendations" string is displayed in the "Request Header" section.