Closed Bug 1558917 Opened 4 months ago Closed 4 months ago

Referrer no longer sent for new tab links

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
firefox67 --- wontfix
firefox68 + verified
firefox69 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1517703 changed the win.openLinkIn API from taking a params with {referrerPolicy, referrerURI} to {referrerInfo} This affects 67

[Tracking Requested - why for this release]: Publishers are expecting the referrer to attribute traffic to pocket

Assignee: nobody → edilee
Priority: -- → P1
Attached image example good referrer

QA steps:

  1. open new tab with articles
  2. open Browser Toolbox (alt-shift-cmd-I)
  3. switch to Network view
  4. click an article (good to note the url to search for it in toolbar)

expected results:
network request to the article (select the url in left panel; probably the first html request) has a Request Header (right panel) containing "Referer: https://getpocket.com/recommendations"

Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9dac8ade6630
Referrer no longer sent for new tab links r=thecount
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Flags: needinfo?(mcoman)
Flags: needinfo?(cmuresan)

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (69.0a1 Build ID - 20190617214029) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Referer: https://getpocket.com/recommendations" string is displayed in the "Request Header" section.

Status: RESOLVED → VERIFIED
Flags: needinfo?(mcoman)
Flags: needinfo?(cmuresan)

Comment on attachment 9072254 [details]
Bug 1558917 - Referrer no longer sent for new tab links

Beta/Release Uplift Approval Request

  • User impact if declined: User interest in publisher's articles don't get attributed back to pocket
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 3
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Updating new tab's link opening API call to the new API
  • String changes made/needed: none
Attachment #9072254 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9072254 [details]
Bug 1558917 - Referrer no longer sent for new tab links

regression fix, approved for 68.0b12

Attachment #9072254 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (68.0b12 Build ID - 20190619234730) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Referer: https://getpocket.com/recommendations" string is displayed in the "Request Header" section.

Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.