Don't build duplicate display items for pagination
Categories
(Core :: Web Painting, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
Details
Attachments
(1 file)
We generally avoid creating duplicate items, since we need to uniquely identify them for retained display lists.
With the frame tree for paginated content, we can end up with an OOF frame being part of one page, but the placeholder for it on a different page. Since we have to descend through the placeholder to build display items for the OOF frame, we can end up needing to DL build though multiple pages (see BuildDisplayListForExtraPage) to create the content for a single page. When we're displaying multiple pages (for print preview), this can result in duplicate items.
Example frame tree:
Page1
Block1
AbsoluteList
Block2
Page2
Block3 (opacity: 0.5)
Block4
Placeholder(Block2)
DL:
Transform(Page1)
BackgroundColor(Block1)
Opacity(Block3)
BackgroundColor(Block2)
Transform(Page2)
Opacity(Block3)
BackgroundColor(Block4)
In this case the opacity item for Block3 is duplicated, since it contains content belonging to both pages.
I think we can tag items that are built from extra pages with the page index of the destination page (tag the first Opacity with page 1) and use that index in the unique key computation.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c872cc627115 Don't allow duplicate items for printing. r=miko
|
||
Comment 3•5 years ago
|
||
Backed out changeset c872cc627115 (Bug 1558937) for reftest failures at 1558937-1.html.
Backout: https://hg.mozilla.org/integration/autoland/rev/48f71175c99922f25dc5311f14db5a72c1b3f726
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=c872cc62711502907b6c99f6c4d157d254d97bc5&selectedJob=253053331
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253053331&repo=autoland&lineNumber=26936
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/69227743aff1 Don't allow duplicate items for printing. r=miko
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•5 years ago
|
Description
•