Closed Bug 1558987 Opened 6 years ago Closed 6 years ago

[Automated review] Please turn off readability-isolate-declaration clang-tidy warnings

Categories

(Developer Infrastructure :: Source Code Analysis, task)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: andi)

Details

Attachments

(1 file)

Bug 1558987 - For clang based static-analysis, disable readability-isolate-declaration. r=ehsan
47 bytes, text/x-phabricator-request
Details | Review

Phabricator URL: https://phabricator.services.mozilla.com/D34457

They aren't very helpful and I think the recommended course of action is for folks to just ignore them, so we may as well not show them in the first place.

Assignee: nobody → bpostelnicu

We did that for pointer declarations to avoid declaration issues in that context.
But indeed, the benefit of that is limited

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/74c12d470a44 For clang based static-analysis, disable readability-isolate-declaration. r=sylvestre

https://hg.mozilla.org/mozilla-central/rev/74c12d470a44

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: