Closed Bug 1559081 Opened 2 months ago Closed 2 months ago

RDM toolbar should be 28px tall to match docked-to-side toolbox

Categories

(DevTools :: Responsive Design Mode, enhancement, P3)

enhancement

Tracking

(firefox69 fixed)

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: fvsch, Assigned: fvsch)

Details

Attachments

(3 files)

The RDM toolbar and the toolbox's toolbar don't have the same height.

  • RDM: 31px (32px with border)
  • Toolbox: 28px (29px with border)

We want them to match, for beauty's sake. :)
Making the RDM toolbar 3px shorter doesn't seem to create issues.

Tentative fix:

/* index.css | resource://devtools/client/responsive.html/index.css */

#toolbar-center-controls, #toolbar-end-controls {
-  grid-auto-rows: 29px;
+  grid-auto-rows: 28px;
-  margin: 1px;
+  margin: 0 1px;
}
Type: defect → enhancement
Priority: -- → P3
Assignee: nobody → florens
Status: NEW → ASSIGNED
Attachment #9072281 - Attachment is patch: false
Attachment #9072281 - Attachment mime type: text/plain → image/png

See how it matches the toolbars in Console (and Network and Debugger) nicely.

Attachment #9072282 - Attachment is patch: false
Attachment #9072282 - Attachment mime type: text/plain → image/png
Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/6aa8a1cb9c5c
Fix RDM toolbar height to match the toolbox; r=mtigley
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.