1559084 - Use of unknown property Ci.nsIClearDataService.CLEAR_PUSH_NOTIFICATIONS

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Mark Banner (:standard8)]

Bug 1489669 introduced an issue in GeckoViewStorageController.jsm:

Use of unknown property Ci.nsIClearDataService.CLEAR_PUSH_NOTIFICATIONS

https://searchfox.org/mozilla-central/rev/227f5329f75bd8b16c6b146a7414598a420260cb/mobile/android/modules/geckoview/GeckoViewStorageController.jsm#45

Looks like it should be: Ci.nsIClearDataService.CLEAR_DOM_PUSH_NOTIFICATIONS.

Bug 1489669 has been uplifted to 68, so maybe this should be as well.

It also implies the test coverage may not be sufficient (bug 1489669 comment 20 says the tests all pass, but this looks to me like when DOM_STORAGES is set, the push notifications wouldn't be cleared).

Comment 1

[Eugen Sawin [:esawin]]

Thanks for catching this!

The tests don't cover clearing push notifications because GeckoView doesn't support push notifications yet.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: Bug 1559084 - [1.0] Fix wrong nsIClearDataService constant name for clearing push notifications.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f46e895eff1c
[1.0] Fix wrong nsIClearDataService constant name for clearing push notifications. r=Standard8

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f46e895eff1c

Comment 5

[Chris Peterson [:cpeterson]]

Eugen, do we need to uplift this fix to GV 68 Beta for Fenix? Or is this "unknown property" error mostly harmless and can ride the trains in GV 69?

Comment 6

[Eugen Sawin [:esawin]]

It can ride trains, we don't support push notifications yet.