1559177 - Structured cloning should have a JS_WriteDouble

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Boris Zbarsky [:bzbarsky]]

For that matter, having a public API to write doubles would be nice too, I suspect.

For now, the code in bug 1420580 is hand-rolling this via bitwise casts to uint32_t, which I think works correctly, modulo not doing any NaN canonicalization. But it's not 100% clear whether we'd want NaN canonicalization in these APIs.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yeah, we need a JS_WriteDouble too, in bug 1420580.

Comment 2

[Jason Orendorff [:jorendorff]]

Prioritizing cross-team requests is hard. How many beers is this worth?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Good question. This is not blocking anything, but it would be nice to clean up the code, basically. Let's say 1 beer? ;)

Not urgent, but would be nice.

Looks like we don't need the "two floats" option anymore, just the "write a double" option.

Comment 4

[Caroline Cullen [:caroline]]

Attachment: Bug 1559177 - Add JS_WriteDouble. r?bzbarsky!,mgaudet!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Caroline, I won't be able to review this, so having me as a blocking reviewer is not a great idea.

Comment 6

[Caroline Cullen [:caroline]]

Attachment: Bug 1559177 - Add JS_ReadDouble. r?smaug!

Depends on D142585

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d8a0764bcaf
Add JS_WriteDouble. r=mgaudet,smaug
https://hg.mozilla.org/integration/autoland/rev/d92ae820685d
Add JS_ReadDouble. r=smaug

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8d8a0764bcaf
https://hg.mozilla.org/mozilla-central/rev/d92ae820685d