Closed Bug 1559190 Opened 5 years ago Closed 5 years ago

Port Bug 1528496 |Correctly fix Bug 1023285 and utf8 addressing header display for jsmime| to SeaMonkey

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.63 wontfix, seamonkey2.53+ fixed, seamonkey2.57esr+ fixed)

RESOLVED FIXED
seamonkey2.66
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.63 --- wontfix
seamonkey2.53 + fixed
seamonkey2.57esr + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.1)

Attachments

(3 files, 3 obsolete files)

Currently error console has messages about this issue that was fixed in TB but not in SM.

It would be good to also take this for 2.53 and 2.57 but it needs the mailnews/ parts from original bug.

Attachment #9071948 - Flags: review?(frgrahl)
Attached patch Equivalent patch for 2.53 (obsolete) — Splinter Review
Attachment #9071950 - Flags: review?(frgrahl)

Is the mailnews part for 2.53 the ones from Bug 1528496 combined?
https://hg.mozilla.org/releases/comm-esr60/rev/f2555e37393955a18fff44e96e5a1e31d49cbe88
https://hg.mozilla.org/releases/comm-esr60/rev/a0eed606d9fff31dfd0c0dc74fa4461c4d03739e

If yes can you split the patch. makes it easier to see what is in the tree.

Flags: needinfo?(iann_bugzilla)

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/bc36808a82ec
Port Bug 1559190 |Correctly fix Bug 1023285 and utf8 addressing header display for jsmime| to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 9071948 [details] [diff] [review]
Port changes to msgHdrViewOverlay.js

upps forgot to r+ a+ before the check-in :)
Attachment #9071948 - Flags: review?(frgrahl)
Attachment #9071948 - Flags: review+
Attachment #9071948 - Flags: approval-comm-esr60+
Summary: Port |Correctly fix Bug 1023285 and utf8 addressing header display for jsmime| to SeaMonkey → Port Bug 1528496 |Correctly fix Bug 1023285 and utf8 addressing header display for jsmime| to SeaMonkey
Target Milestone: --- → seamonkey2.66
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/39836474eb69
Fix undefined variable. rs=bustage-fix
Comment on attachment 9071950 [details] [diff] [review]
Equivalent patch for 2.53

Needs to be fixed for undefined variable. Will be in Bills build for testing.
Attachment #9071950 - Flags: review?(frgrahl)
Attached patch Full fixed patch for 2.53 (obsolete) — Splinter Review

As you pointed out, it also needs part 1 of bug 1528496 porting too.

Attachment #9071950 - Attachment is obsolete: true
Flags: needinfo?(iann_bugzilla)
Attachment #9072376 - Flags: review?(frgrahl)

As requested complete backport including TB part.
SM port should be the same as for c-c plus the bustage fix.

Attachment #9072376 - Attachment is obsolete: true
Attachment #9072376 - Flags: review?(frgrahl)
Attachment #9072378 - Flags: review?(frgrahl)
Comment on attachment 9072378 [details] [diff] [review]
Full backport of bug 1528496 for 2.53

r+ a+ for 2.53
Attachment #9072378 - Flags: review?(frgrahl)
Attachment #9072378 - Flags: review+
Attachment #9072378 - Flags: approval-comm-release+

Split patch mail(news) part from Bug 1528496 r+/a+ retained

Attachment #9072378 - Attachment is obsolete: true
Attachment #9073362 - Flags: review+
Attachment #9073362 - Flags: approval-comm-release+

Split patch suite part r+/a+ retained

Attachment #9073363 - Flags: review+
Attachment #9073363 - Flags: approval-comm-release+

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b6c0eb7db38288902d10410ee93f005d9ad101e9
Back out bug 1023285 (rev 1ecabc4781e3) and fix handling of raw UTF-8 in headers properly| and Introduce EncodedHeaderW() using ParseEncodedHeaderW().r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/1e8b66322f682e449be86d5b32c93f32d89cfdce
Port |Correctly fix Bug 1023285 and utf8 addressing header display for jsmime| to SeaMonkey. r=frg a=frg

Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: