1559200 - Add explanatory text to about:cache that sizes are only for subset of entries

Status: RESOLVED FIXED

(Core :: Networking: Cache, task, P3)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[Manuel Bucher [:manuel]]

The about:cache page gets generated in this file: https://searchfox.org/mozilla-central/rev/606cdd34860e42611fceba025314864cd293a43b/netwerk/protocol/about/nsAboutCache.cpp#80-95

Comment 3

[edgul]

sizes are only for subset of entries

1. Why is this the case, anyway? Exact phrasing might also be helpful here for good-first-bug purposes.
2. Do we need to consult UX/UI on this kind of page?
3. Should this only visible on about:cache?storage= or should it also be visible on about:cache?storage=disk and about:cache?storage=memory?

Comment 4

[Valentin Gosu [:valentin]]

(In reply to Ed Guloien [:edgul] from comment #3)

sizes are only for subset of entries

1. Why is this the case, anyway? Exact phrasing might also be helpful here for good-first-bug purposes.

I think it means that the size of an entry displayed in about:cache shows the size of the data, not the size of the file that's stored on disk - which also contains metadata, security-info, response headers, etc.

2. Do we need to consult UX/UI on this kind of page?

Not really. Your average user doesn't know it exists, and it's not localized as far as I know.

3. Should this only visible on about:cache?storage= or should it also be visible on about:cache?storage=disk and about:cache?storage=memory?

I think only the subpages are affected, not about:cache.

I'm not sure if what we want here is to also show the size of the file on disk, which would be non-trivial, or just to add a note to the page that says something like Data sizes refer to the size of response body and doesn't reflect how much disk space the file occupies.
If we want another column to display the used disk space, I think we can use diskStorageSizeInKB.

Comment 5

[Sean Kim [:sekim]]

Attachment: Bug 1559200 - Add explanatory text to about:cache that sizes are only for subset of entries r?valentin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb915f29821a
Add explanatory text to about:cache that sizes are only for subset of entries r=valentin,necko-reviewers,desktop-theme-reviewers

Comment 7

[Iulian Moraru]

Backed out for causing xpcshell failures.

• Push with failures

• Failure log

• Backout link

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73c692f89a1f
Add explanatory text to about:cache that sizes are only for subset of entries r=valentin,necko-reviewers,desktop-theme-reviewers

Comment 9

[Cosmin Sabou [:CosminS]]

Failures in comment 7 are from https://bugzilla.mozilla.org/show_bug.cgi?id=1894995#c5. This has been relanded and it will be closed as fixed when it reaches mozilla-central.

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/73c692f89a1f