Closed Bug 1559207 Opened 5 years ago Closed 5 years ago

Make XULPersist::AttributeChanged a bit faster in the common case

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file)

Bug 1559207 - Make XULPersist::AttributeChanged a bit faster in the common case, r=bdahl
47 bytes, text/x-phabricator-request
Details | Review

The normal case should be that there isn't persist attribute. By reordering the code a bit we can avoid at least extra AddRef/Release calls.

Patch coming.

GetAttr returns false if the attribute isn't there at all.

Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/863f3c173d34
Make XULPersist::AttributeChanged a bit faster in the common case, r=bdahl

https://hg.mozilla.org/mozilla-central/rev/863f3c173d34

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: