1559211 - Blank space when closing bookmark sidebar

Status: VERIFIED FIXED

(Core :: Graphics, defect, P3)

Description

[Colin]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

1. go to https://bugzilla.mozilla.org
2. press ctrl-b to open bookmarks bar
3. press ctrl-b to close bookmarks bar

Actual results:

blank space on right side of browser, same size as the bookmarks menu. Stays until the page is updated or the window loses focus

Expected results:

no blank space

Comment 1

[Colin]

Regression, occurs in latest nightly build

Comment 2

[Alice0775 White]

I can reproduce the issue on Nightly69.0a1 windows10.
After closed sidebar, the black header bar would not expand to the right.

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a91efd693851d156f5680c88e6f91d12406ec3fe&tochange=94b369f38c536a4cc3b308311b1e88825e581ff5

Regressed by: Bug 1558482

Ryan,
Your bunch of patch seems to cause the regression. Can you please look into this?

Comment 3

[Alice0775 White]

https://developer.mozilla.org/en-US/ is also affected

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1559211 - Fallback to conservative visible rect for top-level remote browsers. r?mattwoodrow

Using a precise visible rect for a top-level browser can cause an
artifact when resizing the window.

I believe this is caused by the message to resize the browser, and
the following paint, to be processed before the message with the
new visible rect.

We can be smarter about this, but in the interest of getting a
quick fix, this commit reverts the behavior here only for top-level
browsers.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1672aa4e79c
Fallback to conservative visible rect for top-level remote browsers. r=mattwoodrow

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f1672aa4e79c

Comment 7

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced this issue on Windows 10x64 with Nightly 69.0a1 (2019-06-13).
Verified as fixed on Windows 10x64, Ubuntu 16.04 and macOS 10.12.6 with 69.0b6.