1559224 - Delete Folder from the Edit Menu has the wrong access key

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Select a folder in the folder pane without selecting a message.

Use the Edit menu and see:
Delete Folder (V) Del

How can that be:
https://searchfox.org/comm-central/rev/bd24161b9edb5cc4864ce10f20ad5a23b104c3f9/mail/base/content/mainCommandSet.inc.xul#120
valueFolderAccessKey="&deleteFolderCmd.accesskey;"

and

https://searchfox.org/comm-central/rev/bd24161b9edb5cc4864ce10f20ad5a23b104c3f9/mail/locales/en-US/chrome/messenger/messenger.dtd#105

So strange. Richard, Aceman, can you see where that goes wrong? Broken on TB 68 beta.

Comment 1

[Jorg K (CEST = GMT+2)]

Richard suggested to find the regression, so very simple:
Select a folder in the folder pane without selecting a message.
Check the "Delete Folder" in the Edit menu, should have a "D" not a "V".

Working in TB 67, so it broke during the 68 cycle. Can you find it for us, Alice? I tried a version of 2019-04-12 and that already has the V. 2018-03-18 has the D. So the range is less than 4 weeks.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=bbad34510f140583fd3c0faac7d5b5558c8a2b99&tochange=3213fa235aef00d065affbe563a05a4469f2e96d
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8c71359d60e21055074ae8bc3dcb796d20f0cbaf&tochange=8063b0c54b888fe1f98774b71e1870cc2267f33f

Suspect:2c10998ca9bc5655db07f18a468527830601ffa6 Richard Marti — Bug 1448939 - Replace mailWindowOverlay.xul with inlining and pre-processing. r=jorgk

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks, Alice, that's bad news. Someone is modifying our delete command :-( - Back to Richard.

Comment 4

[Richard Marti (:Paenglab)]

I tried moving the <commandset id="mailEditMenuItems"> around and it was inferior with showing wrong menuitems like Remove Contact.

I don't really know how this <commandsets> are working. I hope Geoff knows more about this and can find what happens here.

Comment 5

[Geoff Lankow (:darktrojan)]

I suspect missing goSetAccessKey calls here are to blame:

https://searchfox.org/comm-central/rev/bd24161b9edb5cc4864ce10f20ad5a23b104c3f9/mail/base/content/mail3PaneWindowCommands.js#108

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1559224-folder-delete-access-key.patch

That was it! What would we do without you?

The only question is, how or why did this work before with the overlay?

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9072088 [details] [diff] [review]
1559224-folder-delete-access-key.patch

(In reply to Richard Marti (:Paenglab) from comment #6)
> What would we do without you?

Frankly, I think we'd be in a dire situation without all his work. So big thank you!

Comment 8

[Jorg K (CEST = GMT+2)]

And I should mention: This was reported to me by Jørgen Rasmussen, so thanks to you, too!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/acbf665ac191
Set the correct delete access key when a folder is selected. r=jorgk DONTBUILD

Comment 10

[Geoff Lankow (:darktrojan)]

(In reply to Richard Marti (:Paenglab) from comment #6)

The only question is, how or why did this work before with the overlay?

I really don't know! How odd…

Comment 11

[Jorg K (CEST = GMT+2)]

TB 68 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/49725ebea8b8812bd90cdeaa288a33e5e27f346b

Comment 12

[Jorg K (CEST = GMT+2)]

Looking good on beta.