1559231 - [motion-1] Support offset-anchor

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, enhancement, P3)

Description

[Boris Chiou [:boris]]

Support <offset-anchor>, which defines an anchor point of the box positioned along the offset path. The anchor point specifies the point of the box which is to be considered as the point that is moved along the offset path.

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1559231 - Support offset-anchor.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1559231 - Make offset-anchor animatable.

Also, update the wpt to address:
https://github.com/w3c/csswg-drafts/issues/3482.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50f92d01c47a
Support offset-anchor. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d47d9f4bf9a9
Make offset-anchor animatable. r=birtles

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18259 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (Bug 1559231) for rusttests build bustages.

Backout: https://hg.mozilla.org/integration/autoland/rev/86d51000fa121629f7f9e2ef9c7b87fc1f2984db

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=d47d9f4bf9a9ea8b816534916292ca446c7543ce&selectedJob=259663424

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=259663424&repo=autoland&lineNumber=12296

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Boris Chiou [:boris]]

Thanks. Didn't see this on my try yesterday. Probably need to rebase these patches.

Comment 9

[Boris Chiou [:boris]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9959291d7d1b9f29e393247761417efe18eb41f7

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb124efa1957
Support offset-anchor. r=emilio
https://hg.mozilla.org/integration/autoland/rev/7c6c3ac5f8fd
Make offset-anchor animatable. r=birtles

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bb124efa1957
https://hg.mozilla.org/mozilla-central/rev/7c6c3ac5f8fd

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 14

[Sebastian Zartner [:sebo]]

Just to be clear on this, offset-anchor and the other Motion Path features are still behind the layout.css.motion-path.enabled preference and do not ship with Firefox 70, right?

Sebastian

Comment 15

[Boris Chiou [:boris]]

(In reply to Sebastian Zartner [:sebo] from comment #14)

Just to be clear on this, offset-anchor and the other Motion Path features are still behind the layout.css.motion-path.enabled preference and do not ship with Firefox 70, right?

Sebastian

Yes. All motion properties, including offset-anchor, are still behind layout.css.motion-path.enabled, which is disabled on beta/release. Later (perhaps Q4), I will file a bug which ships these properties, and will mark it dev-doc-needed and cc you. (of course, will send a intend to ship mail).

Comment 16

[Sebastian Zartner [:sebo]]

(In reply to Boris Chiou [:boris] from comment #15)

(In reply to Sebastian Zartner [:sebo] from comment #14)

Just to be clear on this, offset-anchor and the other Motion Path features are still behind the layout.css.motion-path.enabled preference and do not ship with Firefox 70, right?

Sebastian

Yes. All motion properties, including offset-anchor, are still behind layout.css.motion-path.enabled, which is disabled on beta/release. Later (perhaps Q4), I will file a bug which ships these properties, and will mark it dev-doc-needed and cc you. (of course, will send a intend to ship mail).

Perfect! Thanks a lot! Normally, the dev-doc-needed flag wouldn't be needed for this then, because it's already mentioned at the Experimental Firefox features page and is not riding the trains yet, but I'll use it to document the property itself in preparation.

Sebastian

Comment 17

[Chris Mills [:cmills]]

I've done some documentation for this property; see https://github.com/mdn/sprints/issues/2105#issuecomment-532633814 and the comments below that one for all the details.

A review would be really great if you get the time; thanks!

I have set this bug to dev-doc-complete; we'll track docs work to update the browser compat data in the release bug when it appears.