1559240 - Subframe crashes don't show the about:framecrashed page anymore.

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1553952 refactored some things, including our subframe crash event structure. One thing it did was make the nsFrameLoader responsible for firing the oop-browser-crashed event, instead of the BrowserParent.

However, when it does this, the frameloader passes along the information about it's top-level BrowsingContext, rather than the one that crashed.

We should have the frameloader fire the event with the BrowsingContext information of the subframe that actually crashed.

We should probably also write a subframe crash test.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

In the interests of getting this ready for the demo next week, I'm going to punt out writing a test for this to a separate bug so this can land hopefully today or tomorrow. The test will require some infrastructure to make it easy for me to crash subframes.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1559240 - Make sure oop-browser-context passes the BrowsingContext of the crashing subframe. r?rhunt

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac140c69f74e
Make sure oop-browser-context passes the BrowsingContext of the crashing subframe. r=rhunt

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ac140c69f74e