1559257 - Stop using docshell's getSameTypeRootTreeItemIgnoreBrowserBoundaries() and getSameTypeParentIgnoreBrowserBoundaries() methods

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Patrick Brosset <:pbro>]

These are the last two JS consumers of the docshell's getSameTypeRootTreeItemIgnoreBrowserBoundaries() and getSameTypeParentIgnoreBrowserBoundaries() methods:

• https://searchfox.org/mozilla-central/rev/1133b6716d9a8131c09754f3f29288484896b8b6/devtools/shared/layout/utils.js#45-58
• https://searchfox.org/mozilla-central/rev/1133b6716d9a8131c09754f3f29288484896b8b6/devtools/shared/layout/utils.js#100-117

These methods don't work super well with fission. It would be great if we could get rid of them.

They seem to have been added this was added 4 years ago in bug 1132475 for devtools to work on b2g devices.
So it's safe to assume we don’t actually need those anymore.

I don't see a case where we would require this helper to go through mozbrowser iframes anyway. The only place where we use it is in RDM where this helper isn't used, and which we'll refactor soon too.

We should be able to replace these with window.top and window.parent I think.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1559257 - Removing getSameTypeRootTreeItemIgnoreBrowserBoundaries and getSameTypeParentIgnoreBrowserBoundaries usage; r?ochameau!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf1bc7abe7b6
Removing getSameTypeRootTreeItemIgnoreBrowserBoundaries and getSameTypeParentIgnoreBrowserBoundaries usage; r=ochameau

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bf1bc7abe7b6