Closed Bug 1559257 Opened 5 months ago Closed 5 months ago

Stop using docshell's getSameTypeRootTreeItemIgnoreBrowserBoundaries() and getSameTypeParentIgnoreBrowserBoundaries() methods

Categories

(DevTools :: General, task)

task
Not set

Tracking

(firefox69 fixed)

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

These are the last two JS consumers of the docshell's getSameTypeRootTreeItemIgnoreBrowserBoundaries() and getSameTypeParentIgnoreBrowserBoundaries() methods:

These methods don't work super well with fission. It would be great if we could get rid of them.

They seem to have been added this was added 4 years ago in bug 1132475 for devtools to work on b2g devices.
So it's safe to assume we don’t actually need those anymore.

I don't see a case where we would require this helper to go through mozbrowser iframes anyway. The only place where we use it is in RDM where this helper isn't used, and which we'll refactor soon too.

We should be able to replace these with window.top and window.parent I think.

Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf1bc7abe7b6
Removing getSameTypeRootTreeItemIgnoreBrowserBoundaries and getSameTypeParentIgnoreBrowserBoundaries usage; r=ochameau
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Assignee: nobody → pbrosset
You need to log in before you can comment on or make changes to this bug.