Closed Bug 1559258 Opened 5 years ago Closed 5 years ago

[Protections Panel] Clean up margins and padding in all panel sections

Categories

(Firefox :: Site Identity, defect, P1)

Product:
Firefox
Component:
Site Identity
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox69 --- wontfix
firefox70 --- verified

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

(Whiteboard: [privacy-panel] [protection-report] [skyline])

Attachments

(2 files)

Bug 1559258 - Clean up margins, paddings, and font-sizes in Protections Panel. r=johannh
47 bytes, text/x-phabricator-request
Details | Review
Screencast showing the new appearance with this patch
1.53 MB, video/webm
Details

For example, the labels in the toggle section have margins, based on which the padding is set for the section.

We should clean all this up by removing padding/margin on individual elements, and setting consistent padding on the boxes.

Whiteboard: [privacy-panel][triage]
Priority: -- → P1
Whiteboard: [privacy-panel][triage] → [privacy-panel]
Whiteboard: [privacy-panel] → [privacy-panel] [protection-report] [skyline]
Depends on: 1567296
No longer depends on: 1567296
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Attachment #9083823 - Attachment mime type: text/plain → video/webm
Attachment #9083820 - Attachment description: Bug 1559258 - Clean up margins and paddings in Protections Panel, increase font-size to spec. r=timhuang → Bug 1559258 - Clean up margins, paddings, and font-sizes in Protections Panel. r=dao
Attachment #9083820 - Attachment description: Bug 1559258 - Clean up margins, paddings, and font-sizes in Protections Panel. r=dao → Bug 1559258 - Clean up margins, paddings, and font-sizes in Protections Panel. r=johannh
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2b29ae6ba20f
Clean up margins, paddings, and font-sizes in Protections Panel. r=johannh

https://hg.mozilla.org/mozilla-central/rev/2b29ae6ba20f

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Regressed by: 1577257
No longer regressed by: 1577257
Regressions: 1577257
Regressions: 1578187
Flags: qe-verify+

From the description on the first comment I've seen that in the 69.0a1 (2019-06-13) the UI in the Privacy Panel has the margins/paddings visible.
I can confirm that the UI corresponds to the description in the comment 2 and is fixed in 70.0b6.

Status: RESOLVED → VERIFIED
status-firefox70: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: