1559272 - On Linux, date-picker pop-up isn't dark in dark theme, and month and hear headers are illegible

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Jonathan Kamens]

Attachment: light-theme.png

I am using Ubuntu Linux 19.04 with GNOME.

When I switch to a dark GNOME theme, the Lightning date-picker pop-up remains light overall, but it looks like the month and year headers in the pop-up are colored as if it is dark, which makes them virtually illegible. Please see the attached screenshots of what the pop-up looks like in a light and dark theme.

Comment 1

[Jonathan Kamens]

Attachment: dark-theme.png

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1559272-apply-systemcolors-to-event.patch

This adds the systemcolors check to the lightning-item-iframe.js to use this colours in the datepicker's minimonth too.

It only check on startup of the event dialog. I think to add a observer in this dialog isn't needed as it doesn't stay open too long and needs to be dynamic for this setting.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4cdda25ab4a7
Apply the systemcolors attribute to the Event dialog too. r=philipp

Comment 4

[Jorg K (CEST = GMT+2)]

This is reported against which version exactly? 7.1, TB 69? Then there wouldn't be any backport necessary.

Comment 5

[Richard Marti (:Paenglab)]

But this happens in 7.0 too.

Comment 6

[Jorg K (CEST = GMT+2)]

TB 68 beta 3 / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/3bce3d48592c0a5607f764e2c0b2e24f6c89ae66