155928 - "Delete Entire Domain xxx" could be better worded

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

In the History window, the Edit menu contains an entry "Delete entire domain
xxx". This is a pretty funny wording :)

Maybe use "Delete all from domain xxx"

Comment 1

[Steve Simms]

See also the discussion on Bug 81065.

Comment 2

[Stefan Borggraefe]

Attachment: Patch

This patch goes with biesi's suggestion. It also fixes the case of the menu
items and changes the access key for "Delete Host" from "l" to "e", because "e"
is wider.

Comment 3

[[e-mail]]

Comment on attachment 157530 [details] [diff] [review]
Patch

I think the no selection ones should say "All From" too. Forwarding review to
aaronlev in case he has an accesskey preference.

Comment 4

[Aaron Leventhal]

Comment on attachment 157530 [details] [diff] [review]
Patch

Shouldn't only the first word be capitalized?

Also, the great majority of users have no clue what a domain is.

I'm not sure if "Delete all from blah" is gramatically correct. It sounds a bit
funny.

May I suggest "Delete history items for %s"

Comment 5

[[e-mail]]

How about "Delete History for [Site and/or Domain] %s" ?

Comment 6

[Stefan Borggraefe]

(In reply to comment #4)
> (From update of attachment 157530 [details] [diff] [review])
> Shouldn't only the first word be capitalized?

I don't think so. The majority of Mozilla's menu items use title case.

> Also, the great majority of users have no clue what a domain is.

Mhh, I don't know another word for "domain". Also trying to explain what it is
inside of the menu item makes it a little bit long. Also the majority of users
probably don't really know what e.g. a "proxy" or a "cache" is, we have to use
these words nevertheless, because this is what these things are called and using
other terms would even be confusing for more advanced users.

> I'm not sure if "Delete all from blah" is gramatically correct. It sounds a bit
> funny.

Ok, I'm not a native speaker.

> May I suggest "Delete history items for %s"

Mhh, this doesn't solve the "domain" problem, since this would expand to

Delete History Items for Site/Host
Delete History Items for Domain

Otherwise you can't distinct the two. Or are you suggesting to consolidate the
two menu items into one?

I like Neil's idea to replace Host with Site, but I don't know a better word for
"domain".

Comment 7

[Aaron Leventhal]

What's the difference between the two options?

For example, would delete everything for domain get rid of anything with
"mozilla.org" in it and delete everything for host is more specific -- e.g. only
bugzilla.mozilla.org stuff?

Comment 8

[Stefan Borggraefe]

(In reply to comment #7)
> What's the difference between the two options?
> 
> For example, would delete everything for domain get rid of anything with
> "mozilla.org" in it and delete everything for host is more specific -- e.g. only
> bugzilla.mozilla.org stuff?

Say you have

http://www.mozilla.org
http://www.mozilla.org/projects/ui/accessibility/
http://bugzilla.mozilla.org
http://bonsai.mozilla.org
http://www.mozillazine.org/news.about.mozilla.org.html

in your history.

Then "Delete entire domain mozilla.org" would delete the first four entries
whereas "Delete all from www.mozilla.org" would delete only the first two
entries. So, yes. ;-)

Comment 9

[Aaron Leventhal]

I'm not trying to be difficult :) In my opinion, having both options is a bit
too complicated for what's needed. Do you agree this is a good time to think
about a better way? I don't want to take up all of your time.

> http://www.mozilla.org
> http://www.mozilla.org/projects/ui/accessibility/
> http://bugzilla.mozilla.org
> http://bonsai.mozilla.org
> http://www.mozillazine.org/news.about.mozilla.org.html

First, isn't it already possible to just use multiple selection and then hit the
delete key? This makes it easy to delete everything starting with
"www.mozilla.org" since they can be sorted to show up together.

Another idea would be these 2 choices:

"Delete everything from *.mozilla.org"
"Delete everything from www.mozilla.org"

This makes the feature 'accessible' from a usability perspective -- otherwise
only 2% of the audience will know what the options mean.

Comment 10

[[e-mail]]

Comment on attachment 157530 [details] [diff] [review]
Patch

OK, I like *.mozilla.org, but are we going to delete everything, or all
history, or what from *.mozilla.org?

Comment 11

[Stefan Borggraefe]

Attachment: Patch V2

Ok, this patch uses the * wildcard to avoid the word "domain":

Delete History for Site %s
Delete History for *.%s
Delete History for Site
Delete History for

The first two strings are for the enabled state, the last two for the disabled.

Comment 12

[Aaron Leventhal]

Comment on attachment 158685 [details] [diff] [review]
Patch V2

r=aaronlev

Is it better to use |var text as an intermediate variable|. Is that more
optimal in JS that to just set gDeleteByHostname.label or gDeleteByDomain.label
directly?

Comment 13

[Stefan Borggraefe]

Comment on attachment 158685 [details] [diff] [review]
Patch V2

> Is it better to use |var text as an intermediate variable|. Is that more
> optimal in JS that to just set gDeleteByHostname.label or gDeleteByDomain.label
> directly?

I don't think this makes a big difference. I could as well directly assign to
the label attribute and eliminate var text. It's just a matter of style/taste.
Let's see if Neil wants var text to die.

Comment 14

[[e-mail]]

Comment on attachment 158685 [details] [diff] [review]
Patch V2

I don't like the deleteDomainNoSelection string. Would it be too bad to put the
word "Domain" back at the end in this case?

>+                text = gHistoryBundle.getFormattedString("deleteHost", [ "" ]);
This is not localizable - the %S might be in the middle of the string. However
I like the idea of not formatting the deleteDomainNoSelection string.

>-            gDeleteByHostname.setAttribute("label", text);
>+
>+            gDeleteByHostname.label = text;
I know at some point this didn't work on a Mac, please check.

Comment 15

[Stefan Borggraefe]

Attachment: Patch V2.1

Addressed Neil's review comments.

This patch still needs testing on Mac OS X.

Comment 16

[Andrew Ferguson]

Is this going to be included with Firefox as well? Thanks.

Comment 17

[Stefan Borggraefe]

timeless: Could you test Patch V2.1 with your Mac build? See comment 14. Thanks! :-)

Andrew: This patch doesn't change a thing in Firefox. If you want this feature
in Firefox, I think you should open a bug with severity enhancement for Firefox
(if there is none yet).

Comment 18

[timeless]

unfortunately my mac isn't building, and that's before bsmedberg rewrote the
build system, i'm dying because of zlib issues in xpinstall

Comment 19

[Stefan Borggraefe]

Comment on attachment 160191 [details] [diff] [review]
Patch V2.1

Asking for reviews again. Since I can't find a Mac user who compiles the suite
to test this patch, I just want to check this in and find someone shortly after
who can test this with a nightly build an a Mac (timeless, *wink* *wink* ;-) ).
I hope this is okay.

Comment 20

[timeless]

that could be arranged *sigh*, i _want_ to build on doppler, it just isn't working

Comment 21

[Stefan Borggraefe]

Fix checked in.

Comment 22

[Stefan Borggraefe]

timeless, does the menu-label update work on Mac OS X?

Comment 23

[Daniel Küstner]

Downloaded a nightly for OS X. On a first glance, everything seems to work.
Stefan: what do you mean with menu label update? I'm attaching a screenshot how
it looks like. When Folders are selected, the menu items are disabled. 

With multiple selection, the menu label seems to be determined by the last
selected item.

Comment 24

[Daniel Küstner]

Attachment: OS X screenshot

Comment 25

[Stefan Borggraefe]

(In reply to comment #23)
> Stefan: what do you mean with menu label update?

I meant the dynamically changing names of the two menu items reflecting the
currently selected history entry. From the screenshot it looks like this works
fine on Mac OS X, too. Thanks for testing! :-)

Comment 26

[Daniel Küstner]

(In reply to comment #25)
> I meant the dynamically changing names of the two menu items reflecting the
> currently selected history entry. From the screenshot it looks like this works
> fine on Mac OS X, too. 

Yes, it does.