1559301 - Straighten up C/C++ standard compiler flags

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

I noticed some weird things while looking at the code, might as well fix them.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1559301 - Straighten up C/C++ standard compiler flags.

• info.type in ('clang-cl', 'clang', 'gcc') is always true since MSVC
  support was removed.
• For some reason, we didn't enforce C++14 on GCC.

Comment 2

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #1)

• For some reason, we didn't enforce C++14 on GCC.

To be clear, this is not a problem currently, because all supported versions of GCC default to C++14. This would become a problem when future versions of GCC default to something else.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79b12fe97ede
Straighten up C/C++ standard compiler flags. r=nalexander

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 9072093 [details]
Bug 1559301 - Straighten up C/C++ standard compiler flags.

Beta/Release Uplift Approval Request

• User impact if declined: This would be nice to have on ESR68, for downstreams that build with GCC, because we don't know if the C++ standard default in GCC will change during the lifetime of ESR68.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Everything relevant to this patch is tested in test_toolchain_configure.py, and it's a noop in practice, as of today.
• String changes made/needed:

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/79b12fe97ede

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9072093 [details]
Bug 1559301 - Straighten up C/C++ standard compiler flags.

approved for 68.0b11

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/193e4087e4c1