1559318 - 13.69% raptor-motionmark-animometer-firefox (linux64-shippable-qr) regression on push 99f335f3f06bc4337b9e7371c8b7b6315d519381 (Tue June 11 2019)

Status: RESOLVED DUPLICATE of bug 1558100

(Core :: Graphics: WebRender, defect)

Description

[Florin Strugariu [:Bebe]]

Raptor has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=99f335f3f06bc4337b9e7371c8b7b6315d519381

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

14% raptor-motionmark-animometer-firefox linux64-shippable-qr opt 47.88 -> 41.32

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21480

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a Treeherder page showing the Raptor jobs in a pushlog format.

To learn more about the regressing test(s) or reproducing them, please see: https://wiki.mozilla.org/Performance_sheriffing/Raptor

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Comment 1

[Sotaro Ikeda [:sotaro]]

There was accidental regression to WebRenderTextureHost::UnbindTextureSource() by Bug 1557105. It was already addressed by Bug 1558100.

Comment 2

[Sotaro Ikeda [:sotaro]]

Performance of raptor-motionmark-animometer-firefox has been restored now.
https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-central,1939091,1,10&series=mozilla-central,1939101,1,10

Comment 4

[Sotaro Ikeda [:sotaro]]

When Bug 1558100 was backed out, raptor-motionmark-animometer-firefox was degraded again. From it, the problem of comment 0 was addressed by Bug 1558100.
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=e4067286f29c6f654bbfa8ecee7871dac10bc39d&newProject=try&newRevision=37091da38a82da5a64d2bb9ef39e07268f52f5dc&framework=10

Comment 5

[Florin Strugariu [:Bebe]]

== Change summary for alert #21525 (as of Wed, 19 Jun 2019 05:52:34 GMT) ==

Improvements:

16% raptor-motionmark-animometer-firefox linux64-shippable-qr opt 41.30 -> 47.85
11% raptor-motionmark-animometer-firefox windows10-64-shippable-qr opt 39.42 -> 43.58
10% raptor-motionmark-animometer-firefox windows10-64-shippable-qr opt 39.52 -> 43.64

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21525