Closed Bug 1559363 Opened 1 year ago Closed 1 year ago

Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 69
Iteration:
69.3 - Jun 10 - 23
Tracking Status
firefox69 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

This was a misunderstanding in bug 1547299. The Google doc didn't spell this out, but the invision doc has a note on this.

Priority: -- → P1
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3c2e1416e88
Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus. r=adw
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Comment on attachment 9072727 [details]
Bug 1559363 - Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus. r=adw

Beta/Release Uplift Approval Request

  • User impact if declined: this is needed for the first quantumbar experiment (bug 1547279)
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): doesn't affect vanilla Firefox, apart from a little code cleanup
  • String changes made/needed:
Attachment #9072727 - Flags: approval-mozilla-beta?

Comment on attachment 9072727 [details]
Bug 1559363 - Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus. r=adw

marco says we don't need this in 68

Attachment #9072727 - Flags: approval-mozilla-beta?
Iteration: --- → 69.3 - Jun 10 - 23
You need to log in before you can comment on or make changes to this bug.