1559363 - Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dão Gottwald [:dao]]

This was a misunderstanding in bug 1547299. The Google doc didn't spell this out, but the invision doc has a note on this.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1559363 - Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus. r=adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3c2e1416e88
Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus. r=adw

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b3c2e1416e88

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9072727 [details]
Bug 1559363 - Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: this is needed for the first quantumbar experiment (bug 1547279)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): doesn't affect vanilla Firefox, apart from a little code cleanup
• String changes made/needed:

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9072727 [details]
Bug 1559363 - Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus. r=adw

marco says we don't need this in 68