Include subframe PIDs in tab hover tooltip

RESOLVED FIXED in Firefox 69

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: Nika, Assigned: Nika)

Tracking

unspecified
mozilla69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Fission Milestone:M4, firefox69 fixed)

Details

Attachments

(1 attachment)

This code sloppily extends the existing (pid annotation to add subframe information.

I'm also open to an alternate mechanism for communicating this information. Apparently this hover tooltip is not accessible to screenreaders, so it may be worthwhile to add an alternate mechanism for that.

In the future it may be worthwhile to add info about the PID to a support page, like about:support. As with fission we use one process per site, it would be possible to correlate iframes to PIDs by comparing the site loaded in them, and looking up the corresponding PID.

Finally, it may also be worthwhile to introduce a nightly-only WebExtension API which is able to read info about which PID is being used for a subframe, which can be then used to provide more flexible out-of-band information.

Type: defect → enhancement
Fission Milestone: --- → M4

This seems okay, but I wonder if it'd be better to use the .webidl changes as a foundation for Abdoulaye's efforts in bug 1559234. Is there utility in getting the list of PIDs without necessarily mapping them to actual <iframe>'s? Or should we put our efforts into making it clearer which <iframe> has which PID?

Flags: needinfo?(nika)

We chatted a bit on slack - Abdoulaye's efforts are much better ergonomically, but this still may be handy in the future for things like oop iframes with no visual presence (like tracking pixels or library loads).

We'll also probably want other tools, but we'll have to grow them as-needed.

Flags: needinfo?(nika)

Hey Abdoulaye - just bringing this to your attention. We might be able to use the osPid that Nika is adding on the WindowGlobalParent directly instead of sending up the process ID from the ContextMenuChild, so perhaps you could base your solution to bug 1559234 off of this patch.

Blocks: 1559234

(In reply to Mike Conley (:mconley) (:⚙️) from comment #4)

Hey Abdoulaye - just bringing this to your attention. We might be able to use the osPid that Nika is adding on the WindowGlobalParent directly instead of sending up the process ID from the ContextMenuChild, so perhaps you could base your solution to bug 1559234 off of this patch.

Sure!
Thank you Nika for your help here.

Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8270b8bdccd8
Show subframe pids in tab hover text, r=mconley

(In reply to :Nika Layzell (busy - slow to reply) from comment #0)

Apparently this hover tooltip is not accessible to screenreaders, so it may be worthwhile to add an alternate mechanism for that.

Making the tab tooltip accessible is covered in bug 1410757. I know how I'd like this to be exposed; it's just not straightforward to implement.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.