Closed Bug 1559418 Opened 1 year ago Closed 1 year ago

Create base Lockwise card

Categories

(Firefox :: Protections UI, enhancement, P1)

68 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: ewright, Assigned: mtigley)

References

Details

(Whiteboard: [protection-report][triage])

Attachments

(1 file)

Create the UI for the Lockwise card, seen in the invision mock

Whiteboard: [protection-report][triage]
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Priority: -- → P1
Attachment #9076090 - Attachment description: Bug 1559418 - Create a base card for Firefox Lockwise. → Bug 1559418 - Create a base card for Firefox Lockwise. r=ewright
Blocks: 1559421
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f8d8b15ccc84
Create a base card for Firefox Lockwise. r=ewright

Backed out changeset f8d8b15ccc84 (bug 1559418) for ESlint failure. CLOSED TREE

Log:
Backed out changeset f8d8b15ccc84 (bug 1559418) for ESlint failure. CLOSED TREE

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f8d8b15ccc84deeed4e98f256ace76ec7ea3733b

Backout:
https://hg.mozilla.org/integration/autoland/rev/e53142c91caf61aa2b7749ef0a3c6bafaff10b6f

Flags: needinfo?(mtigley)

Hey Micah, is there anything blocking landing this? :)

Flags: needinfo?(mtigley)

(In reply to Johann Hofmann [:johannh] from comment #6)

Hey Micah, is there anything blocking landing this? :)

Nope. Will be landing this shortly!

Flags: needinfo?(mtigley)
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d8e1fec25e7
Create a base card for Firefox Lockwise. r=ewright

Backed out changeset 4d8e1fec25e7 (bug 1559418) for failing at browser_parsable_css.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/219c494a7bab0155fd85fe79c0ad68108b95c96b

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=255977323&resultStatus=testfailed%2Cbusted%2Cexception&revision=4d8e1fec25e7987732dcc9fc26ea89c27d3bc9a2

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255977323&repo=autoland&lineNumber=1471

Log snippet:

16:45:04 INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-svg-marker-anon-child’. Ruleset ignored due to bad selector." on resource://gre/res/svg.css because of whitelist item {"sourceName":"/\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua|pluginproblem)\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
16:45:04 INFO - Buffered messages finished
16:45:04 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for chrome://browser/content/protections.css: Error in parsing value for ‘grid-gap’. Declaration dropped. -
16:45:04 INFO - Stack trace:
16:45:04 INFO - chrome://mochikit/content/browser-test.js:test_ok:1576
16:45:04 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:messageIsCSSError:294
16:45:04 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:515
16:45:04 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1346
16:45:04 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1381
16:45:04 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1209
16:45:04 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
16:45:04 INFO - Not taking screenshot here: see the one that was previously logged
16:45:04 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | All the styles (226) loaded without errors. - Got 1, expected 0
16:45:04 INFO - Stack trace:
16:45:04 INFO - chrome://mochikit/content/browser-test.js:test_is:1591
16:45:04 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:516
16:45:04 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1346
16:45:04 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1381
16:45:04 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1209
16:45:04 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
16:45:04 INFO - Leaving test bound checkAllTheCSS

Flags: needinfo?(mtigley)
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c13a10992cc
Create a base card for Firefox Lockwise. r=ewright
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.