1559419 - SeaMonkey build error: No rule to make target '../../../dist/bin/distribution/extensions', needed by 'pack-ext'

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Frank-Rainer Grahl (:frg)]

If no extensions in distribution/extensions are built the mach pack-ext build step fails because the directory is not created.

d:/seabuild/c-c-cl/obj-x86_64-pc-mingw32/dist/bin/extensions/e2fda1a4-762b-4020-b5ad-a41df1933103.xpi/; c:/mozilla-build/bin/zip.ex
e -r9mX ../e2fda1a4-762b-4020-b5ad-a41df1933103.xpi.xpi * -x */.mkdir.done; cd ..; rm -rf d:/seabuild/c-c-cl/obj-x86_64-pc-mingw32/
dist/bin/extensions/e2fda1a4-762b-4020-b5ad-a41df1933103.xpi; fi
1:29.65 Packaging lightning-7.1a1.en-US.xpi...
1:29.65 if test -d "d:/seabuild/c-c-cl/obj-x86_64-pc-mingw32/dist/bin/extensions/lightning-7.1a1.en-US.xpi"; then cd d:/seabuild/c-
c-cl/obj-x86_64-pc-mingw32/dist/bin/extensions/lightning-7.1a1.en-US.xpi/; c:/mozilla-build/bin/zip.exe -r9mX ../lightning-7.1a1.en-
US.xpi.xpi * -x */.mkdir.done; cd ..; rm -rf d:/seabuild/c-c-cl/obj-x86_64-pc-mingw32/dist/bin/extensions/lightning-7.1a1.en-US.xpi
; fi
1:29.65 mozmake.EXE[5]: Leaving directory 'd:/seabuild/c-c-cl/obj-x86_64-pc-mingw32/comm/suite/app'
1:29.65 mozmake.EXE[5]: Entering directory 'd:/seabuild/c-c-cl/obj-x86_64-pc-mingw32/comm/suite/app'
1:29.65 mozmake.EXE[5]: *** No rule to make target '../../../dist/bin/distribution/extensions', needed by 'pack-ext'. Stop.
1:29.65 mozmake.EXE[5]: Leaving directory 'd:/seabuild/c-c-cl/obj-x86_64-pc-mingw32/comm/suite/app'
1:29.65 mozmake.EXE[4]: *** [Makefile:112: tools] Error 2
1:29.65 mozmake.EXE[4]: Leaving directory 'd:/seabuild/c-c-cl/obj-x86_64-pc-mingw32/comm/suite/app'
1:29.65 mozmake.EXE[3]: *** [d:/seamonkey/comm-central/config/recurse.mk:101: comm/suite/app/tools] Error 2
1:29.65 mozmake.EXE[3]: Leaving directory 'd:/seabuild/c-c-cl/obj-x86_64-pc-mingw32'
1:29.66 mozmake.EXE[2]: *** [d:/seamonkey/comm-central/config/recurse.mk:34: tools] Error 2
1:29.66 mozmake.EXE[2]: Leaving directory 'd:/seabuild/c-c-cl/obj-x86_64-pc-mingw32'

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1559419-distext.patch

See https://dxr.mozilla.org/comm-central/source/comm/suite/app/Makefile.in#107

tools::

• $(NSINSTALL) -D $(DIST)/bin/distribution/extensions
  @$(MAKE) pack-ext STAGEDIST="$(DIST)/bin/extensions"
  @$(MAKE) pack-ext STAGEDIST="$(DIST)/bin/distribution/extensions"

Comment 2

[Frank-Rainer Grahl (:frg)]

Broken by removing suite/extensions/Makefile.in:
https://bug1231349.bmoattachments.org/attachment.cgi?id=9054675

Comment 3

[Ian Neal]

Comment on attachment 9072195 [details] [diff] [review]
1559419-distext.patch

r/a=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5ad70183bb37
Always create the distribution/extensions directory in dist/bin. r=IanN

Comment 5

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/3750833e7038b0080f64c02ab920586fa5f9f50c

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9072195 [details] [diff] [review]
1559419-distext.patch

Same patch as for the other trees.

Comment 7

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/08ac177ba9c4927de16534dce5b4d172cb7fb69e