1559428 - Create base Proxy card

Status: VERIFIED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Erica Wright [:ewright]]

Create the UI for the Proxy card, seen in the invision mock

Comment 1

[Erica Wright [:ewright]]

This should show when the proxy addon has not been installed, and hide when installed.

Comment 2

[Micah [:mtigley] (she/her)]

(In reply to Erica Wright [:ewright] from comment #1)

This should show when the proxy addon has not been installed, and hide when installed.

In addition, we should only show if the user's location is in the US.

Comment 3

[Micah [:mtigley] (she/her)]

Attachment: Bug 1559428 - Create base Proxy card.

Comment 4

[Johann Hofmann [:johannh]]

For context on why this is hidden: we are holding off on publicly adding this (including the download link etc.) until it is actually being released to the public. The release date as communicated currently is August 20th, which would give us enough time to merge this before 70 goes to Beta, but it will have to be cut from initial QA testing for protection report. I think that's not a big issue.

Please don't merge until then :)

Comment 5

[Micah [:mtigley] (she/her)]

Unassigning myself from this since I will not be on this project after August 17. This has been recently rebased with tests and is localization-ready.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this still in progress? Can you help find an owner and solidify when this will go live? Thanks!

Comment 7

[Erica Wright [:ewright]]

(In reply to Liz Henry (:lizzard) from comment #6)

Is this still in progress? Can you help find an owner and solidify when this will go live? Thanks!

Hi! We've just been discussing this today. It was paused for confidentiality reasons, but as Proxy will be released in beta tomorrow we will now be merging this card and trying to uplift it for 70. :mtigley is working on it, it should be finished shortly.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks!

Comment 9

[Johann Hofmann [:johannh]]

Private Network was announced and we're landing this soon. I think that means we can lift the confidential flag here.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c21d5ca1ae2b
Create base Proxy card. r=ewright,fluent-reviewers,johannh,flod

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c21d5ca1ae2b

Comment 12

[Micah [:mtigley] (she/her)]

Comment on attachment 9079152 [details]
Bug 1559428 - Create base Proxy card.

Beta/Release Uplift Approval Request

• User impact if declined: Card for telling users located in the US about Firefox Secure Proxy will be missing.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The Secure Proxy card is hidden by default behind a pref.
• String changes made/needed:

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9079152 [details]
Bug 1559428 - Create base Proxy card.

Needed for Skyline, verified in nightly, ok for uplift for beta 7.

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7e4f97016b60

Comment 15

[Erica Wright [:ewright]]

I've been testing this from Canada, and adding "en-US" to my accepted languages, but it seems the string is actually "en-us" lowercase when I add US English to my accepted languages in about:preferences. We should probably be checking with the case irrelevant. I'll open another bug, but would appreciate if someone in the US would verify what their default language setting is.

Comment 16

[Bogdan Surd, QA [:bsurd, NI]]

@Liz, does QA need to test this? Micah marked it with no in Comment 12. If yes, are there any details with set-up instructions for QA to be able to test this?

I would like to mention that we don't have access to the mocks either. Could you please give us access to them if this will need to be tested?

Comment 17

[Betsy Mikel [:betsymi]]

The mocks won't be accurate as the copy is not yet final and the name isn't final either.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Betsy, we're heading into beta 11 of 14 so time is short.
When will you have the final copy ?
Erica, can you talk with Bogdan about what testing you need here?

Comment 19

[Betsy Mikel [:betsymi]]

I don't know. We don't have a name yet.

Comment 20

[Erica Wright [:ewright]]

Bogden,
Here is a public link for the mocks: https://mozilla.invisionapp.com/share/W6T7F6RMJ39#/360923276_Protection_Report
The proxy card is at the bottom of the report.
you can enable this by setting:
intl.accept_languages = "en-us"
browser.search.region = "US"
browser.contentblocking.report.proxy.enabled = true
also ensure the proxy extension is not installed.

If these cases are set then the proxy card will show and should look like the mock.

Comment 21

[Bogdan Surd, QA [:bsurd, NI]]

Verified with the latest Nightly (71.0a1 from 2019-09-26) and Beta (70.0b9) available. The option is displayed after making the modifications in Comment 20. Marking as verified.