Closed Bug 1559472 Opened 6 years ago Closed 6 years ago

Errors from passport cause tracebacks and 500's

Categories

(Taskcluster :: Services, defect)

Product:
Taskcluster
Component:
Services
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1562897

People

(Reporter: dustin, Assigned: hassan)

Details

For example, hitting /login/github/callback without a code logs

TokenError: The code passed is incorrect or expired.
    at Strategy.OAuth2Strategy.parseErrorResponse (/app/node_modules/passport-oauth2/lib/strategy.js:329:12)
    at Strategy.OAuth2Strategy._createOAuthError (/app/node_modules/passport-oauth2/lib/strategy.js:376:16)
    at /app/node_modules/passport-oauth2/lib/strategy.js:166:45
    at /app/node_modules/passport-github/lib/strategy.js:77:16
    at /app/node_modules/oauth/lib/oauth2.js:209:7
    at passBackControl (/app/node_modules/oauth/lib/oauth2.js:134:9)
    at IncomingMessage.<anonymous> (/app/node_modules/oauth/lib/oauth2.js:157:7)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1129:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

and exits. This should be handled more gracefully..

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.