1559484 - Add a test for reloading a document with OOP iframe

Status: RESOLVED WONTFIX

(Core :: DOM: Content Processes, task, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

This appears to happen in https://searchfox.org/mozilla-central/rev/d62176d3d70bbf9ad86a5d444f9edada52cbc2b1/docshell/base/BrowsingContextGroup.cpp#76. My guess is that the changes made in bug 1555287 cause there to be a state where not every BrowsingContext is visited by only walking cached & toplevel BCs (as they've been detached as children), so this assert fails.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Andreas, is there any chance you could look into this?

Comment 2

[Andreas Farre [:farre]]

Bug 1555287 has been backed out so let's keep an eye if the signature disappears.

Comment 3

[Andreas Farre [:farre]]

Attachment: Bug 1559484 - Test that you can reload a cross domain iframe.

Comment 4

[Andreas Farre [:farre]]

I can confirm that with Bug 1555287 Comment 14 this hits the assert, and with out that patch it doesn't.

Comment 5

[Neha Kochar [:neha]]

The patch is ready but we really need it only once we start enabling WPT-fission, so pushing this out to M5 to focus on M-fis for M4.

Comment 6

[Chris Peterson [:cpeterson]]

Deferring to Fission Nightly (M6) because adding new tests doesn't strictly block Fission dogfooding (M5).

Comment 7

[Chris Peterson [:cpeterson]]

The DOM Fission team is relying on feature teams to debug and fix Fission failures in their tests. If the failure looks like a bug in Fission's DOM or IPC changes, you can send the bug back to me.

We're hoping to enable Fission for a subset of Nightly users in early Q3, so we would like WPT tests to be green for Fission by end of Q2. Whether a particular test failure actually blocks shipping Fission is up to the discretion of the feature team. You all would know better than the DOM Fission which test failures are most important.

You can enable Fission when running WPT tests locally using mach wpt --enable-fission.

Comment 8

[Chris Peterson [:cpeterson]]

Nika declares WPT-Fis test bugs should be tracked for Fission M6b.