Closed Bug 1559501 Opened 1 year ago Closed 11 months ago

Implement icon support through setContextualTip

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
70.2 - Jul 22 - Aug 4
Tracking Status
firefox70 --- fixed

People

(Reporter: okonaraddi, Assigned: okonaraddi)

References

Details

Attachments

(1 file, 1 obsolete file)

Iteration: --- → 69.4 - Jun 24 - Jul 7
Iteration: 69.4 - Jun 24 - Jul 7 → 70.1 - Jul 8 - 21
Attachment #9077561 - Attachment description: Bug 1559501 - Implement set/get icon r=mak! → Bug 1559501 - Implement set/get icon r=adw!,r=mak!
Attachment #9077561 - Attachment description: Bug 1559501 - Implement set/get icon r=adw!,r=mak! → Bug 1559501 - Implement icon support and use setDefaultTip in place of individual setters/getters for icon and text elements r=adw!,mak!
Attachment #9077561 - Attachment description: Bug 1559501 - Implement icon support and use setDefaultTip in place of individual setters/getters for icon and text elements r=adw!,mak! → Bug 1559501 - Implement icon support and use setContextualTip in place of individual setters/getters for icon and text elements r=adw!,mak!
Iteration: 70.1 - Jul 8 - 21 → ---
Summary: Implement set/get icon → Implement icon support through setContextualTip

As mentioned in Bug 1559495 Comment 1 , icon support will include setting the default, theme and various sized icons through the setContextualTip's details parameter. Currently, the contextual tip API supports setting an icon through setContextualTip and the API supports default icons of various sizes and theme icons if they're defined in the manifest as defaults. Since we're removing defaults from the manifest, web extensions should be able to provide icons for light/dark themes and high/low res screens through the browser.urlbar.contextualTip.setContextualTip function.

Attachment #9077561 - Attachment is obsolete: true
Iteration: --- → 70.2 - Jul 22 - Aug 4
Attachment #9081510 - Attachment description: Bug 1559501 - Implement icon support through setContextualTip r=adw!,mak!,mixedpuppy! → Bug 1559501 - Implement icon support through setContextualTip r=adw!,mixedpuppy!
Attachment #9081510 - Attachment description: Bug 1559501 - Implement icon support through setContextualTip r=adw!,mixedpuppy! → Bug 1559501 - Implement icon support through setContextualTip r=adw!
Pushed by okonaraddi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3939226182e9
Implement icon support through setContextualTip r=adw,mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 11 months ago11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.