Closed
Bug 1559545
Opened 5 years ago
Closed 5 years ago
Start using the rust representation for grid-related things.
Categories
(Core :: CSS Parsing and Computation, task)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
Grid is one of the last bits that isn't using the new thing. It's the last user of nsStyleCoord, too.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Right now we do a lot of useless string copying. In order to avoid transcoding
to utf-16 during layout, make sure to use nsCString at a few related places.
I may revisit this since we're storing other line names as atoms in some places.
So it may be better to just use atoms everywhere.
But that'd be a different patch either way.
Depends on D35116
|
|
Assignee | |
Updated•5 years ago
|
Type: defect → task
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75767e9242a5 Use more ffi-friendly types in grid template areas. r=mats https://hg.mozilla.org/integration/autoland/rev/26f9c324cf42 Use servo for the representation of grid template areas. r=mats
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/75767e9242a5
https://hg.mozilla.org/mozilla-central/rev/26f9c324cf42
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•