Closed Bug 1559548 Opened 5 years ago Closed 5 years ago

Dismissing a download highlight makes it go away and reappear

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 69
Iteration:
69.4 - Jun 24 - Jul 7
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox68 --- wontfix
firefox69 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Regression)

Details

(Keywords: github-merged, regression)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5152
52 bytes, text/x-github-pull-request
Details | Review

Looks like this happens for both activity stream and discovery stream highlights

Just tested 67.0.2 and it's broken there

Blocks: pocket-newtab
Assignee: nobody → edilee
Iteration: --- → 69.4 - Jun 24 - Jul 7
Priority: -- → P1
Component: Activity Streams: Newtab → New Tab Page

Ah doh. Bug 1488462 removed the blocked links check because of performance issues with downloaded data uris.

Regressed by: 1488462
No longer regressed by: 1496092
Blocks: 1563243

https://hg.mozilla.org/mozilla-central/rev/fe000c5de938

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (69.0a1 Build ID - 20190705064618) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the download highlight no longer reappears after it was dismissed

Status: RESOLVED → VERIFIED
status-firefox69: fixed → verified
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: