Closed Bug 1559551 Opened 5 months ago Closed 5 months ago

Add Send Feedback menuitem to the ellipsis menu

Categories

(Firefox :: about:logins, task, P3)

task

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
firefox69 --- verified

People

(Reporter: jaws, Assigned: JSON_voorhees)

References

Details

(Whiteboard: [passwords:management] [skyline] )

Attachments

(1 file)

The Send Feedback menuitem should take the user to https://www.surveygizmo.com/s3/5036102/Lockwise-feedback?ver=%version% (which should be stored in a pref). The menuitem should have a label of "Send Feedback" and use the notification icon (chrome://browser/skin/notification-icons/desktop-notification.svg).

Flags: qe-verify+
Assignee: nobody → djustice
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86a122959152
Add Feedback menuitem to ellipsis menu.?jaws r=fluent-reviewers,jaws,flod

Backed out for failures on /test_menu_button.html

backout: https://hg.mozilla.org/integration/autoland/rev/d6571848ba1b4d80fac14c7fdba19caf10049b2e

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=86a122959152cc9da40441317032715d04cd32c0&searchStr=mochitest-chrome-1proc-1%2Cm-1proc%28c1%29&selectedJob=252842111

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=252841908&repo=autoland&lineNumber=2019

[task 2019-06-21T18:47:19.459Z] 18:47:19 INFO - TEST-PASS | browser/components/aboutlogins/tests/chrome/test_menu_button.html | .menuitem-preferences should not be focused before tabbing to it
[task 2019-06-21T18:47:19.461Z] 18:47:19 INFO - Buffered messages finished
[task 2019-06-21T18:47:19.463Z] 18:47:19 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/chrome/test_menu_button.html | waiting for preferencesItem to get focus
[task 2019-06-21T18:47:19.465Z] 18:47:19 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:275:18
[task 2019-06-21T18:47:19.466Z] 18:47:19 INFO - SimpleTest.waitForCondition/interval<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1043:7
[task 2019-06-21T18:47:19.468Z] 18:47:19 INFO - setInterval handlerSimpleTest.waitForCondition@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1041:18
[task 2019-06-21T18:47:19.470Z] 18:47:19 INFO - SimpleTest.promiseWaitForCondition/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1063:10
[task 2019-06-21T18:47:19.471Z] 18:47:19 INFO - SimpleTest.promiseWaitForCondition@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1062:10
[task 2019-06-21T18:47:19.473Z] 18:47:19 INFO - test_menu_open_close@chrome://mochitests/content/chrome/browser/components/aboutlogins/tests/chrome/test_menu_button.html:61:20
[task 2019-06-21T18:47:19.474Z] 18:47:19 INFO - async
nextTick/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1793:34
[task 2019-06-21T18:47:19.476Z] 18:47:19 INFO - asyncnextTick@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1809:11
[task 2019-06-21T18:47:19.477Z] 18:47:19 INFO - setTimeout handler
SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:684:43
[task 2019-06-21T18:47:19.479Z] 18:47:19 INFO - add_task@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1753:7
[task 2019-06-21T18:47:19.480Z] 18:47:19 INFO - @chrome://mochitests/content/chrome/browser/components/aboutlogins/tests/chrome/test_menu_button.html:29:1
[task 2019-06-21T18:47:19.482Z] 18:47:19 INFO - Not taking screenshot here: see the one that was previously logged

Flags: needinfo?(djustice)

https://phabricator.services.mozilla.com/D35379 has been updated, added test for feedback item existence check

Flags: needinfo?(djustice)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82f44a6420c5
Add Feedback menuitem to ellipsis menu.?jaws r=fluent-reviewers,jaws,flod
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [passwords:management] [skyline]

Confirmed with 69.0b7 on Windows 10, macOS 10.14, Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla69 → Firefox 69
You need to log in before you can comment on or make changes to this bug.