1559552 - New bookmarks don't immediately show up in already open about:newtab

Status: RESOLVED INVALID

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

Pretty sure this was how highlights behaved before. Doesn't work on activity stream or discovery stream. Also tested in 67.0.2 and doesn't work

Comment 1

[Ciprian Muresan [:cmuresan], Ecosystem QA]

@Ed did this stop working when you use the card's context menu option?

If I navigate to a page and then bookmark that seems to work for me and the bookmark appears in the Highlights section on the next new tab that I open.

Comment 2

[Ed Lee :Mardak]

This happens for both in-page context menu and the star button in address bar. And to be clear, I meant in existing open new tabs.

But trying to find where this regressed, I guess I had just forgotten the expected behavior of Highlights. ;) Pretty sure it never immediately showed bookmarks for existing pages but did show up on the next new tab. I believe if somebody bookmarked a pocket story, it would change its label to Bookmarked but not move to Highlights so that the cards don't immediately jump around leaving the user needing to search for where's the card just interacted with.

For discovery stream, I suppose there's a slight functionality regression for in-new-tab bookmarking of pocket stories as one needs to re-open the context menu to realize it's successfully bookmarked. This should get fixed as part of bug 1540842.