1559563 - Attempt to inline StaticPrefs accessors

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Jean-Yves Avenard [:jya]]

In bug 1554334, actual StaticPrefs code was moved to Preferences.cpp outside the header.

While there are advantages to do so, it has been mentioned that we lost inlining of the code.

I don't believe that this will cause measurable differences, but may as well do that.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn!

This allows for the compiler to inline the code where appropriate.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn!

We can avoid testing if we are running in the parent process.

Depends on D35124

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/535345f0ff55
P1. Move StaticPrefs accessor back to header file. r=njn
https://hg.mozilla.org/integration/autoland/rev/5f0f37756053
P2. Small optimization of `Once` StaticPrefs accessor. r=njn

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/535345f0ff55
https://hg.mozilla.org/mozilla-central/rev/5f0f37756053

Comment 6

[Boris Zbarsky [:bzbarsky]]

jya, thank you!