Attempt to inline StaticPrefs accessors

RESOLVED FIXED in Firefox 69

Status

()

defect
RESOLVED FIXED
Last month
19 days ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Regression, {regression})

unspecified
mozilla69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox67 unaffected, firefox68 unaffected, firefox69 fixed)

Details

Attachments

(2 attachments)

In bug 1554334, actual StaticPrefs code was moved to Preferences.cpp outside the header.

While there are advantages to do so, it has been mentioned that we lost inlining of the code.

I don't believe that this will cause measurable differences, but may as well do that.

This allows for the compiler to inline the code where appropriate.

We can avoid testing if we are running in the parent process.

Depends on D35124

Depends on: 1559675

Bugbug thinks this bug is a defect, but please change it back in case of error.

Type: task → defect
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/535345f0ff55
P1. Move StaticPrefs accessor back to header file. r=njn
https://hg.mozilla.org/integration/autoland/rev/5f0f37756053
P2. Small optimization of `Once` StaticPrefs accessor. r=njn
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

jya, thank you!

You need to log in before you can comment on or make changes to this bug.