Closed
Bug 1559642
Opened 6 years ago
Closed 6 years ago
--enable-warnings-as-errors fails due to -D ellipsis-inclusive-range-patterns with Rust 1.37
Categories
(Core :: Preferences: Backend, defect)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: jbeich, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
Probably regressed by https://github.com/rust-lang/rust/pull/61342
$ rustc -vV
rustc 1.37.0-nightly
binary: rustc
commit-hash: 991c719a1d0f95c37ed7ea56bdb38bcc2a6246b9
commit-date: 2019-06-08
host: x86_64-unknown-freebsd
release: 1.37.0-nightly
LLVM version: 8.0
$ echo "ac_add_options --enable-warnings-as-errors" >>.mozconfig
$ ./mach build
[...]
error: `...` range patterns are deprecated
--> modules/libpref/parser/src/lib.rs:632:25
|
632 | c @ b'0'...b'9' => value += (c - b'0') as u16,
| ^^^ help: use `..=` for an inclusive range
|
= note: `-D ellipsis-inclusive-range-patterns` implied by `-D warnings`
error: `...` range patterns are deprecated
--> modules/libpref/parser/src/lib.rs:633:25
|
633 | c @ b'A'...b'F' => value += (c - b'A') as u16 + 10,
| ^^^ help: use `..=` for an inclusive range
error: `...` range patterns are deprecated
--> modules/libpref/parser/src/lib.rs:634:25
|
634 | c @ b'a'...b'f' => value += (c - b'a') as u16 + 10,
| ^^^ help: use `..=` for an inclusive range
error: aborting due to 3 previous errors
error: Could not compile `prefs_parser`.
| Assignee | ||
Updated•6 years ago
|
Assignee: nobody → n.nethercote
| Assignee | ||
Comment 1•6 years ago
|
||
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2247ce136d5
Fix -D ellipsis-inclusive-range-patterns warnings. r=froydnj
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•