1559824 - Opening multiple links at once when the tabbar is overflowed usually won't scroll all of the tabs into view

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Itiel]

This is a regression from bug 1483354.

STR:

1. Windows 10, latest Nightly, fresh profile
2. Enable the bookmarks toolbar, create 4 bookmarks and put all of them in a folder
3. Overflow the tabbar with new tabs
4. Middle click the folder (you can also right click > Open All in Tabs to reproduce this but for some reason middle clicking it makes the reproducibility rates go up)
5. Don't scroll the tabbar

AR:
In ~90% of the times, you'll see 2 tabs on the tabbar, and in order to see the other 2 you'll have to scroll the tabbar.

ER:
Prior to bug 1483354, all 4 tabs were immediately visible on the tabbar upon opening all bookmarks without having to scroll to see the rest.

This is similar to bug 1351466.

Comment 1

[Itiel]

More specifically, the regression is from the "use promiseDocumentFlushed to execute tabstrip scrolling after creating a background tab" patch.

Comment 2

[:Gijs (he/him)]

Can you verify that the issue is gone in the opt windows builds from https://treeherder.mozilla.org/#/jobs?repo=try&revision=4665f6f4c4020aca7c7d51c1962fe4a9d4e22a1e once those are done (probably about ~1h from now) ? I think I got the issue, but I had less luck than you reproducing on my (slower?) arm windows device so I'm not 100% sure.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1559824 - ensure the right tab is visible when opening more than 1 background tab, r?dao

Comment 4

[Itiel]

(In reply to :Gijs (he/him) from comment #2)

Can you verify that the issue is gone in the opt windows builds from https://treeherder.mozilla.org/#/jobs?repo=try&revision=4665f6f4c4020aca7c7d51c1962fe4a9d4e22a1e once those are done (probably about ~1h from now) ? I think I got the issue, but I had less luck than you reproducing on my (slower?) arm windows device so I'm not 100% sure.

Not sure when the download link should be in this link.
Can you tell me where I should click to get to the try build? So I'd know for the next time (ni? for this).

Comment 5

[:Gijs (he/him)]

(In reply to Itiel from comment #4)

(In reply to :Gijs (he/him) from comment #2)

Can you verify that the issue is gone in the opt windows builds from https://treeherder.mozilla.org/#/jobs?repo=try&revision=4665f6f4c4020aca7c7d51c1962fe4a9d4e22a1e once those are done (probably about ~1h from now) ? I think I got the issue, but I had less luck than you reproducing on my (slower?) arm windows device so I'm not 100% sure.

Not sure when the download link should be in this link.
Can you tell me where I should click to get to the try build? So I'd know for the next time (ni? for this).

Sorry for making assumptions here. You can click either of the "B" jobs (green letters) in the rows that list "opt" - so "Windows 2012 opt" and "Windows 2012 x64 opt" (you could also try the debug or asan builds but they will be very slow). A panel comes up at the bottom. Switch to "Job Details" at the top of that panel if necessary, and find "target.zip" in the pane underneath it ("find in page" can help, for some reason the list is not alphabetical). The x64 row of course is 64-bit Firefox, the row without is 32-bit.

For your convenience, 32-bit is: https://queue.taskcluster.net/v1/task/PEjOI4vRR6Cnp3Ml09nfmw/runs/0/artifacts/public/build/target.zip , 64-bit is https://queue.taskcluster.net/v1/task/ZJcYMJ_HSbyUy31756x4Jg/runs/0/artifacts/public/build/target.zip .

Thank you!

Comment 6

[Itiel]

(In reply to :Gijs (he/him) from comment #5)

(In reply to Itiel from comment #4)

(In reply to :Gijs (he/him) from comment #2)

Can you verify that the issue is gone in the opt windows builds from https://treeherder.mozilla.org/#/jobs?repo=try&revision=4665f6f4c4020aca7c7d51c1962fe4a9d4e22a1e once those are done (probably about ~1h from now) ? I think I got the issue, but I had less luck than you reproducing on my (slower?) arm windows device so I'm not 100% sure.

Not sure when the download link should be in this link.
Can you tell me where I should click to get to the try build? So I'd know for the next time (ni? for this).

Sorry for making assumptions here. You can click either of the "B" jobs (green letters) in the rows that list "opt" - so "Windows 2012 opt" and "Windows 2012 x64 opt" (you could also try the debug or asan builds but they will be very slow). A panel comes up at the bottom. Switch to "Job Details" at the top of that panel if necessary, and find "target.zip" in the pane underneath it ("find in page" can help, for some reason the list is not alphabetical). The x64 row of course is 64-bit Firefox, the row without is 32-bit.

Good to know, thanks!

Yes, the issue seems to be fixed on your try build.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b852d85a5345
ensure the right tab is visible when opening more than 1 background tab, r=dao

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b852d85a5345

Comment 9

[:Gijs (he/him)]

Comment on attachment 9072734 [details]
Bug 1559824 - ensure the right tab is visible when opening more than 1 background tab, r?dao

Beta/Release Uplift Approval Request

• User impact if declined: Broken scroll-to-tab when opening multiple tabs
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment #0. Note that verification happened with a try build before now.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small JS-only change in tab handling that changes which tab we attempt to scroll into view.
• String changes made/needed: Nope

Comment 10

[Itiel]

Fixed on latest Nightly.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9072734 [details]
Bug 1559824 - ensure the right tab is visible when opening more than 1 background tab, r?dao

approved for 68.0b13

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b1de8ed9345f

Comment 13

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed on latest Beta 68.0b13, Build ID 20190624133534, on Windows 10 and Ubuntu 18.04.