1559859 - Always release mWidget in UiCompositorControllerChild::Destroy()

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

In UiCompositorControllerChild::Destroy(), mWidget is released only when mIsOpen is true. But it should be always released if it exist.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1559859 - Always release mWidget in UiCompositorControllerChild::Destroy()

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1954bdab630687ee89bd88c2a95d63c18082741a

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0f2fc39f250
Always release mWidget in UiCompositorControllerChild::Destroy() r=kats

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b0f2fc39f250

Comment 5

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9072582 [details]
Bug 1559859 - Always release mWidget in UiCompositorControllerChild::Destroy()

Beta/Release Uplift Approval Request

• User impact if declined: When Bug 1547760 is uplifted, this patch is necessary. If the patch is not applied during uplifting Bug 1547760, it might cause memory leak if gecko is shutdown with error.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1547760
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is relatively simple.
• String changes made/needed: none

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9072582 [details]
Bug 1559859 - Always release mWidget in UiCompositorControllerChild::Destroy()

approved for 68.0b12

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/c5a64922e1a1