1559919 - Finish the WorkerHolder cleanup

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect, P1)

Description

[Andrea Marchesini [:baku]]

In this bug I'm planning to:

1. introduce IPCWorkerRef - something in between WeakWorkerRef and StrongWorkerRef for IPC messages. IPCWorkerRef keeps the worker thread alive but it doesn't prevent the worker shutdown.
2. Remove the remaining WorkerHolder classes
3. Remove WorkerHolderToken
4. Get rid of WorkerHolder completely.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 1 - IndexedDB doesn't use WorkerHolder, r?asuth

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 2 - Remove dead code in PerformanceStorageWorker, r?asuth

Depends on D35220

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 3 - IPCWorkerRef r?asuth

Depends on D35221

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 4 - IPCWorkerRef in ServiceWorkerContainerChild, r?asuth

Depends on D35222

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 5 - IPCWorkerRef in ServiceWorkerRegistrationChild, r?asuth

Depends on D35223

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 6 - IPCWorkerRef in ServiceWorkerChild, r?asuth

Depends on D35224

Comment 7

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 7 - IPCWorkerRef in ClientManagerChild, r?asuth

Depends on D35225

Comment 8

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 8 - Get rid of WorkerHolderToken, r?asuth

Depends on D35226

Comment 9

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 9 - Notification API ported to WorkerRef, r?asuth

Depends on D35227

Comment 10

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 10 - CacheWorkerHolder ported to WorkerRef, r?asuth

Depends on D35228

Comment 11

[Andrea Marchesini [:baku]]

Attachment: Bug 1559919 - Finish the WorkerHolder cleanup - part 11 - WorkerHolder replaced by WorkerRef, r?asuth

Depends on D35229

Comment 12

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7b32e2402673560618e3a96acea1ddd9580b491&selectedJob=252474538

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce9a22196682
Finish the WorkerHolder cleanup - part 1 - IndexedDB doesn't use WorkerHolder, r=asuth
https://hg.mozilla.org/integration/autoland/rev/d6a7b9f0cc2f
Finish the WorkerHolder cleanup - part 2 - Remove dead code in PerformanceStorageWorker, r=asuth
https://hg.mozilla.org/integration/autoland/rev/65a2c0e1eb1e
Finish the WorkerHolder cleanup - part 3 - IPCWorkerRef r=asuth
https://hg.mozilla.org/integration/autoland/rev/e1cae929e9c5
Finish the WorkerHolder cleanup - part 4 - IPCWorkerRef in ServiceWorkerContainerChild, r=asuth
https://hg.mozilla.org/integration/autoland/rev/e6ee63850e41
Finish the WorkerHolder cleanup - part 5 - IPCWorkerRef in ServiceWorkerRegistrationChild, r=asuth
https://hg.mozilla.org/integration/autoland/rev/7b84345b4725
Finish the WorkerHolder cleanup - part 6 - IPCWorkerRef in ServiceWorkerChild, r=asuth
https://hg.mozilla.org/integration/autoland/rev/5af07a1087d3
Finish the WorkerHolder cleanup - part 7 - IPCWorkerRef in ClientManagerChild, r=asuth
https://hg.mozilla.org/integration/autoland/rev/c07ebc67fee0
Finish the WorkerHolder cleanup - part 8 - Get rid of WorkerHolderToken, r=asuth
https://hg.mozilla.org/integration/autoland/rev/ca37d95ba0f7
Finish the WorkerHolder cleanup - part 9 - Notification API ported to WorkerRef, r=asuth
https://hg.mozilla.org/integration/autoland/rev/e5cb87a13c69
Finish the WorkerHolder cleanup - part 10 - CacheWorkerHolder ported to WorkerRef, r=asuth
https://hg.mozilla.org/integration/autoland/rev/9dc000511baf
Finish the WorkerHolder cleanup - part 11 - WorkerHolder replaced by WorkerRef, r=asuth

Comment 16

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ce9a22196682
https://hg.mozilla.org/mozilla-central/rev/d6a7b9f0cc2f
https://hg.mozilla.org/mozilla-central/rev/65a2c0e1eb1e
https://hg.mozilla.org/mozilla-central/rev/e1cae929e9c5
https://hg.mozilla.org/mozilla-central/rev/e6ee63850e41
https://hg.mozilla.org/mozilla-central/rev/7b84345b4725
https://hg.mozilla.org/mozilla-central/rev/5af07a1087d3
https://hg.mozilla.org/mozilla-central/rev/c07ebc67fee0
https://hg.mozilla.org/mozilla-central/rev/ca37d95ba0f7
https://hg.mozilla.org/mozilla-central/rev/e5cb87a13c69
https://hg.mozilla.org/mozilla-central/rev/9dc000511baf