1559984 - Thread pane no longer styled with different background while search is in progress (TB 68)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Body searches on large folders can take a while. Therefore the thread pane's background was changed while the search was ongoing.

This is no longer the case in TB 68 beta.

Did that get lost with the dark theme work?

Comment 1

[Jorg K (CEST = GMT+2)]

Isn't that this "isBusy" thing? That should still work:
https://searchfox.org/comm-central/search?q=isBusy&case=false&regexp=false&path=*.css

Comment 2

[Richard Marti (:Paenglab)]

No, https://hg.mozilla.org/comm-central/rev/997a46907023#l10.77

Comment 3

[Jorg K (CEST = GMT+2)]

Well, I'm a bit surprised that long-standing functionality was removed and that Windows changes where reviewed by someone who's not on Windows :-(

Reading bug 1508159, there's a talk of a "nothing found" display instead of the striped background, but I don't see that either.

In short, can we make this work again, or do I have to add something to my userChrome now?

Comment 4

[Jorg K (CEST = GMT+2)]

Looks like this still works in userChrome.css:

#threadTree[filterActive="searching"] {
  background: linear-gradient(#ffffcc, #ffffcc);
/*  background-color: #ffffcc; */
}

#threadTree[filterActive="matches"] {
  background: linear-gradient(#f2f9fc, #f2f9fc);
/*  background-color: #f2f9fc; */
}

#threadTree[filterActive="nomatches"] {
  background: repeating-linear-gradient(-45deg, #fff0f4,
              #fff0f4 5px, white 5px, white 10px);
}

The background-color doesn't appear to work, but the background does. Also, it's a little sad that the backend still sets those properties/attributes and we don't use them any more as we used to:
https://searchfox.org/comm-central/search?q=filterActive&case=false&regexp=false&path=

Comment 5

[Richard Marti (:Paenglab)]

The icon is no more shown because of the tree de-XBL. This doesn't work https://searchfox.org/comm-central/rev/630f951ef8efd45af34ef07382851a4ab3184d6c/mail/base/content/quickFilterBar.css#71 because the tree-stack is now in shadow-DOM.

I'll look at it this evening.

Comment 6

[Jorg K (CEST = GMT+2)]

Discussed with Magnus: If we make the "nothing found" work again, we could also have a "search in progress".

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #6)

Discussed with Magnus: If we make the "nothing found" work again, we could also have a "search in progress".

But not for beta because of the string freeze.

Comment 8

[Jorg K (CEST = GMT+2)]

I think we'll have a "late string freeze" this time. BTW, can't that you be an animated arrow? No strings?

Comment 9

[Richard Marti (:Paenglab)]

Attachment: 1559984-QFB-search-fix.patch

This fixes the "Not found" display after the tree de-XBL which moved the tree-stack into the shadow-DOM.

I also added a spinner when it is searching.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 9072864 [details] [diff] [review]
1559984-QFB-search-fix.patch

Yes, this works, I liked the colours better. Where did you get the "spinner" from? I was searching some larger news groups and it's not all that pleasant. It looks like it's rotating clock-wise, and then stalls and rotates the other way around. That's of course just an effect that the eye and the brain make up. Something smoother would be better. Maybe we do a follow-up, but right now, it's the only patch I have.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d2122e452112
Fix the QFB "not found" display and add a search spinner. r=jorgk

Comment 12

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #10)

Comment on attachment 9072864 [details] [diff] [review]
1559984-QFB-search-fix.patch

Yes, this works, I liked the colours better. Where did you get the "spinner"
from? I was searching some larger news groups and it's not all that
pleasant. It looks like it's rotating clock-wise, and then stalls and
rotates the other way around. That's of course just an effect that the eye
and the brain make up. Something smoother would be better. Maybe we do a
follow-up, but right now, it's the only patch I have.

I made it myself. I haven't so big folders that I see the spinner. You could try to increase the dur="2s" to 3s or 4s in the SVG to see if this helps when it turns slower.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/320e458f6629
Follow-up: Increase spinner duration to 6s to minimise visual artefacts. r=me DONTBUILD

Comment 14

[Jorg K (CEST = GMT+2)]

The problem is that the rotation isn't smooth but jerky. So it can jerk into a forward position that visually looks as if it rotated backwards (like some M$ progress bars). I tried up to 8s and found that 6s was best. All polish.

As I said, very easy to see doing a body search on a large news folder. Once on beta, I'll see it in my 129.000+ messages bugmail folder.

Comment 15

[Jorg K (CEST = GMT+2)]

TB 68 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/3910676454e7428f44784c10f030fedfd74e52b1 (merged the two changesets)

Comment 16

[Jorg K (CEST = GMT+2)]

Works OK on the beta, but how can I get my userChrome.css to work again?

#threadTree[filterActive="searching"] {
  background: linear-gradient(#ffc, #ffc);
}

#threadTree[filterActive="nomatches"] {
  background: repeating-linear-gradient(-45deg, #fff0f4,
              #fff0f4 5px, white 5px, white 10px);
}

Add ! important? I wouldn't mind combining the two.

Comment 17

[Richard Marti (:Paenglab)]

Yes, but then the images are no more here. The first rule could be changed to background-color: #ffc !important; The second would be more complicated because two background-images are used.

Comment 18

[Jorg K (CEST = GMT+2)]

I still think it's sad that the

#threadTree[filterActive="matches"] {
  background: linear-gradient(#f2f9fc, #f2f9fc);
/*  background-color: #f2f9fc; */
}

was removed. This helps to realise that only a subset of the messages in the folder is showm. People who do many things at once (context switching) tend to forget that they were doing a search and wonder why messages are missing.

Any idea to improve that?

Comment 19

[Richard Marti (:Paenglab)]

Unfortunately not. But in the QFBar is also a display with how many messages are found. Isn't this enough?

Comment 20

[Jorg K (CEST = GMT+2)]

Well, I had the idea to display a tick (checkmark, "Häckchen") in the background. That's the opposite of "nothing found".

Comment 21

[Richard Marti (:Paenglab)]

I think this would be too much. When no message is shown it's good to show why, either because it is still searching or no message is found. But when something is found you don't need an additional feedback in form of a checkmark behind the messages.