Closed Bug 1559994 Opened 1 year ago Closed 1 year ago

Blue key doorhanger anchor icon upon automatically saving a generated password

Categories

(Toolkit :: Password Manager, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox70 --- verified

People

(Reporter: MattN, Assigned: sfoster)

References

Details

(Whiteboard: [passwords:capture-UI] [passwords:generation] [skyline])

Attachments

(2 files)

Highlight the doorhanger icon as blue when automatically saving a generated password (not when it was only filled but not auto-saved).

Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Attachment #9077260 - Attachment description: Bug 1559994 - (WIP) Add 'attention'-styled dismissed doorhanger when auto-saving a generated password → Bug 1559994 - Add 'attention'-styled dismissed doorhanger when auto-saving a generated password. r?MattN
Blocks: 1559993

Turns out we needed to:

  • Add a notifySaved argument to promptToSavePassword. This is added to the signatures for both desktop and mobile implementations
  • Use the extraAttr notification option (was previously undocumented) to highlight the dismissed notification icon until the doorhanger is shown. this gets us the correct behavior when more than one tab has this kind of dismissed notification - we don't want showing one to clear the attention state on any others

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d1db3bbce24461d51e709e40acf9a356ec4e577

Whiteboard: [passwords:capture-UI] [passwords:generation] → [passwords:capture-UI] [passwords:generation] [skyline]
Whiteboard: [passwords:capture-UI] [passwords:generation] [skyline] → [passwords:generation] [skyline]
Whiteboard: [passwords:generation] [skyline] → [passwords:capture-UI] [passwords:generation] [skyline]
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8f487edf311
Add 'attention'-styled dismissed doorhanger when auto-saving a generated password. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/dd1dbf88a31b
Add notifySaved argument to promptToChangePassword on nsILoginManagerPrompter.

Verified - Fixed on latest Nightly 70.0a1 (2019-07-28) (64-bit) on Windows 10, Ubuntu 18.04 and MacOS 10.14.
If the generated password is saved, the key will get highlighted with blue color.
Upon clicking on the key and toggling the doorhanger, the key will no longer be highlighted.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.