Closed Bug 1559997 Opened 3 years ago Closed 3 years ago

Use a monospace password font in generated autocomplete

Categories

(Toolkit :: Password Manager, enhancement, P3)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox69 --- verified
firefox70 --- verified

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [passwords:generation] [skyline])

Attachments

(2 files, 1 obsolete file)

To make it easier for users to distinguish characters like O vs. 0, use a monospace font.

Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED

Also fix the autocomplete footer size.

Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/c7eea91ebea2
Use a monospace password font in generated autocomplete. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [passwords:generation] [skyline]
Flags: qe-verify+
Attached image is this font monospace or not.png (obsolete) —
  1. I am attempting to verify this bug, but I am not sure I understand where the monospace font is being used. Is it when generating a password?

  2. How do you think it would be best to actually verify whether is monospace or not?
    Is this extension going to help me?

Flags: needinfo?(MattN+bmo)

(In reply to Bodea Daniel [:danibodea] from comment #4)

Created attachment 9081929 [details]
is this font monospace or not.png

  1. I am attempting to verify this bug, but I am not sure I understand where the monospace font is being used. Is it when generating a password?

This bug is about the font of the password in the autocomplete popup, we don't change the website font.

  1. How do you think it would be best to actually verify whether is monospace or not?

I think it will be fairly clear when you see it, each character should take the same width and it should be a serif font. One way to check would be to edit your generated password to include characters that look similar (e.g. upper case O and zero, lowercase L and one, etc.) and ensure you can distinguish them… we never generate a password with them so you will need to edit the password in the field after generating (in recent Nightly) then clear the field and the edited password should be suggested.

Is this extension going to help me?

Since you need to inspect the browser UI I don't think it will help.

Flags: needinfo?(MattN+bmo)

Hey, sorry Matt, but we seem to be confused about where this monospace font is being implemented. Can you please explain with some steps or a screenshot?

Flags: needinfo?(MattN+bmo)

See how the text of the generated password is a serif font and is a different font than the label "Use a securely generated password"?

Attachment #9081929 - Attachment is obsolete: true
Flags: needinfo?(MattN+bmo)

The font displayed on the Password Manager drop-down (I think it would be more intuitive to call it that, rather than the password autocomplete pop-up) is monospace, serif and easily readable.
This implementation has been verified on Windows 10, Mac OS 10.13.6 and Ubuntu 18.04 in Nightly v70.0a1 and Beta v69.0b10.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.